luci-base: conversion of ucitrack handling from uci to json

[feckert]

Description:

The ucitrack configuration under /etc/config defines which service must be restarted on a LuCI change. This uci file defines how all this works together. Additionally there are uci-defaults scripts in the various applications that add additional configurations parameters to this ucitrack file if a service must be reloaded/restarted if a uci change was made in this application.

There are some problems with the current implementation:

• The uci should be used to configure the system and not for this kind of reload/restart dependency handling on LuCI changes.
• On a system update with configuration restore of the uci file ucitrack the new behavior on LuCI reload/restart could not take into account because the new file is not be used.

In these two repositories, the change must then also be made after the merge.
openwrt/packages#23879
openwrt/routing#1062

• This PR is not from my main or master branch 💩, but a separate branch ✅
• Each commit has a valid ✒️ Signed-off-by: <my@email.address> row (via git commit --signoff)
• Each commit and PR title has a valid 📝 <package name>: title first line subject for packages
• ( Preferred ) Mention: @jow-
• Description: (describe the changes proposed in this PR)

[jow-]

In general this seems fine. My gut feeling is that a lot of these are redundant nowadays, every package with a procd enabled init script that installs a reload handler or does uci to command line conversion should be covered by generic logic already. Only ucitrack entries for servies having legacy init scripts or no init scripts at all should remain (or preferably, the underlying packages should be ported to procd) (I overlooked that you already removed quite a bunch)

In your commit messages please change deletet to deleted.

[systemcrash]

@feckert

For those out there (posterity, and googlers who find this) who have PRs in the works, they just migrate from ucitrack to json file and everything just 'works'?

Delete this:

#!/bin/sh

uci -q batch <<-EOF >/dev/null
	delete ucitrack.@app[-1]
	add ucitrack app
	set ucitrack.@app[-1].init=appd
	commit ucitrack
EOF

exit 0

Do this:

{
	"config": "appd",
	"init": "appd"
}

(How) Does one handle the following in JSON? e.g.

#!/bin/sh

rm -f /tmp/luci-indexcache
exit 0

[systemcrash]

I also did not understand this bit:

the new behavior on LuCI reload/restart could not take into account because the new file is not be used

[feckert]

@systemcrash

(How) Does one handle the following in JSON? e.g.

#!/bin/sh

rm -f /tmp/luci-indexcache
exit 0

This is no longer needed. We already add this to every package in luci.mk in general. See the following lines in luci.mk that get called as a post script during packages installation.

luci/luci.mk

Lines 227 to 230 in 291dd24

	[ -n "$${IPKG_INSTROOT}" ] || { \
	rm -f /tmp/luci-indexcache.*
	rm -rf /tmp/luci-modulecache/
	killall -HUP rpcd 2>/dev/null

I also did not understand this bit:

the new behavior on LuCI reload/restart could not take into account because the new file is not be used

This means that if I keep the /etc/config/ucitrack file during a system upgrade and this file has changed, the new file will not be used. And the LuCI will not react as intended to a LuCI change.