Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

treewide: upgrade ucitrack handling to use json #1062

Merged
merged 2 commits into from
Apr 16, 2024

Conversation

feckert
Copy link
Member

@feckert feckert commented Apr 11, 2024

Maintainer: @stargieg @PolynomialDivision @wfleurant
Compile tested: no
Run tested: no

Description:
This depends on pullrequest in the LuCI feed.

The ucitrack configuration under /etc/config defines which service must be restarted on a LuCI change. This uci file defines how all this works together. Additionally there are uci-defaults scripts in the various applications that add additional configurations parameters to this ucitrack file if a service must be reloaded/restarted if a uci change was made in this application.

There are some problems with the current implementation:

  • The uci should be used to configure the system and not for this kind of reload/restart dependency handling on LuCI changes.
  • On a system update with configuration restore of the uci file ucitrack the new behavior on LuCI reload/restart could not take into account because the new file is not be used.

Conversion of the 'uci-defaults' script for ucitrack handling to the new
json processing.

Signed-off-by: Florian Eckert <fe@dev.tdt.de>
Conversion of the 'uci-defaults' script for ucitrack handling to the new
json processing.

Signed-off-by: Florian Eckert <fe@dev.tdt.de>
@feckert
Copy link
Member Author

feckert commented Apr 16, 2024

The base PR has been merged.
Since I have no commit rights for this feed.
Can one of those @BKPepe @aparcar who have this merge this change?

@BKPepe BKPepe merged commit d4e9f92 into openwrt:master Apr 16, 2024
6 of 12 checks passed
@feckert feckert deleted the pr/20240411-ucitrack branch April 16, 2024 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants