Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add public service controller for manage loadbalancer service #1685

Merged
merged 1 commit into from
Sep 1, 2023

Conversation

River-sh
Copy link
Contributor

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind feature
/sig network

What this PR does / why we need it:

This controller focuses on automating the management of LoadBalancer services

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

@openyurt-bot
Copy link
Collaborator

@River-sh: GitHub didn't allow me to assign the following users: luc99hen, wangchenglong01.

Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind feature
/sig network

What this PR does / why we need it:

This controller focuses on automating the management of LoadBalancer services

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@River-sh River-sh force-pushed the dev_raven_public_svc branch 3 times, most recently from 59fa0ee to 0618706 Compare August 31, 2023 02:46
@River-sh River-sh changed the title Dev raven public svc add public service controller for manage loadbalancer service Aug 31, 2023
@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Merging #1685 (f7b27c2) into master (8b94570) will decrease coverage by 0.68%.
Report is 1 commits behind head on master.
The diff coverage is 31.46%.

@@            Coverage Diff             @@
##           master    #1685      +/-   ##
==========================================
- Coverage   52.46%   51.79%   -0.68%     
==========================================
  Files         162      164       +2     
  Lines       19091    19729     +638     
==========================================
+ Hits        10016    10218     +202     
- Misses       8150     8542     +392     
- Partials      925      969      +44     
Flag Coverage Δ
unittests 51.79% <31.46%> (-0.68%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...rvice/gateway_internal_service_enqueue_handlers.go 0.00% <0.00%> (ø)
...r/raven/gatewaypickup/gateway_pickup_controller.go 24.89% <0.00%> (-1.57%) ⬇️
...service/gateway_public_service_enqueue_handlers.go 0.00% <0.00%> (ø)
...publicservice/gateway_public_service_controller.go 39.14% <39.14%> (ø)

... and 1 file with indirect coverage changes

@sonarcloud
Copy link

sonarcloud bot commented Aug 31, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

No Coverage information No Coverage information
6.3% 6.3% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@rambohe-ch
Copy link
Member

/lgtm

@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: luc99hen, rambohe-ch, River-sh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openyurt-bot openyurt-bot added the lgtm lgtm label Sep 1, 2023
@openyurt-bot openyurt-bot merged commit 1a5366b into openyurtio:master Sep 1, 2023
12 of 15 checks passed
luckymrwang added a commit to luckymrwang/openyurt that referenced this pull request Sep 20, 2023
…fix_calico

* 'master' of https://github.com/openyurtio/openyurt:
  Add status info to YurtAppSet/YurtAppDaemon (openyurtio#1702)
  fix: add the logic of removing the finalizer (openyurtio#1695)
  Fix work dir nested `yurthub/yurthub` (openyurtio#1693)
  Add yurtappoverrider (openyurtio#1684)
  modify the logic for judging static pods and combine the utils for pod and node (openyurtio#1689)
  chore: slice loop replace (openyurtio#1690)
  unified expression about DaemonSet (openyurtio#1698)
  improve controller names (openyurtio#1687)
  add gateway public service controller (openyurtio#1685)
  feat: add token format checking to yurtadm join process (openyurtio#1681)
  add gateway internal service controller (openyurtio#1677)
  fix: yurt-iot-dock cannot be dynamically deployed in platformadmin (openyurtio#1679)
  unserve v1alpha1 version of platformadmin crd (openyurtio#1659)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants