Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: slice loop replace #1690

Merged
merged 1 commit into from
Sep 11, 2023
Merged

chore: slice loop replace #1690

merged 1 commit into from
Sep 11, 2023

Conversation

testwill
Copy link
Contributor

@testwill testwill commented Sep 5, 2023 •
edited
Loading

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

other Note

@testwill
chore: slice loop replace
63fecd4 
Signed-off-by: guoguangwu <guoguangwu@magic-shield.com>
@openyurt-bot
Copy link
Collaborator

@testwill: GitHub didn't allow me to assign the following users: your_reviewer.

Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

other Note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sonarcloud
Copy link

sonarcloud bot commented Sep 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@openyurt-bot openyurt-bot added the size/XS size/XS: 0-9 label Sep 5, 2023
@codecov
Copy link

codecov bot commented Sep 11, 2023

Codecov Report

Merging #1690 (63fecd4) into master (8b8c6e1) will increase coverage by 0.01%.
Report is 1 commits behind head on master.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #1690      +/-   ##
==========================================
+ Coverage   51.75%   51.76%   +0.01%     
==========================================
  Files         163      163              
  Lines       19716    19715       -1     
==========================================
+ Hits        10204    10206       +2     
+ Misses       8542     8540       -2     
+ Partials      970      969       -1
Flag Coverage Δ
unittests 51.76% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...ager/controller/yurtappset/adapter/adapter_util.go 66.31% <0.00%> (+0.69%) ⬆️

... and 1 file with indirect coverage changes

@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rambohe-ch, testwill

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rambohe-ch
Copy link
Member

/lgtm

@openyurt-bot openyurt-bot added the approved approved label Sep 11, 2023
@openyurt-bot openyurt-bot added the lgtm lgtm label Sep 11, 2023
@openyurt-bot openyurt-bot merged commit 0dcd845 into openyurtio:master Sep 11, 2023
13 of 14 checks passed
@testwill testwill deleted the slice branch September 11, 2023 06:17
@open-digger-bot open-digger-bot bot mentioned this pull request Sep 13, 2023
Closed
luckymrwang added a commit to luckymrwang/openyurt that referenced this pull request Sep 20, 2023
@luckymrwang
Merge branch 'master' of https://github.com/openyurtio/openyurt into …
8d54d5a 
…fix_calico

* 'master' of https://github.com/openyurtio/openyurt:
  Add status info to YurtAppSet/YurtAppDaemon (openyurtio#1702)
  fix: add the logic of removing the finalizer (openyurtio#1695)
  Fix work dir nested `yurthub/yurthub` (openyurtio#1693)
  Add yurtappoverrider (openyurtio#1684)
  modify the logic for judging static pods and combine the utils for pod and node (openyurtio#1689)
  chore: slice loop replace (openyurtio#1690)
  unified expression about DaemonSet (openyurtio#1698)
  improve controller names (openyurtio#1687)
  add gateway public service controller (openyurtio#1685)
  feat: add token format checking to yurtadm join process (openyurtio#1681)
  add gateway internal service controller (openyurtio#1677)
  fix: yurt-iot-dock cannot be dynamically deployed in platformadmin (openyurtio#1679)
  unserve v1alpha1 version of platformadmin crd (openyurtio#1659)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rambohe-ch rambohe-ch rambohe-ch approved these changes

@huangyuqi huangyuqi Awaiting requested review from huangyuqi

@zzguang zzguang Awaiting requested review from zzguang

Assignees

@rambohe-ch rambohe-ch

Labels
approved approved lgtm lgtm size/XS size/XS: 0-9
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@testwill @openyurt-bot @rambohe-ch