Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup: io/ioutil #813

Merged
merged 1 commit into from
Apr 26, 2022
Merged

cleanup: io/ioutil #813

merged 1 commit into from
Apr 26, 2022

Conversation

cndoit18
Copy link
Member

Signed-off-by: cndoit18 cndoit18@outlook.com

What type of PR is this?

/kind good-first-issue

What this PR does / why we need it:

Please see https://golang.org/doc/go1.16#ioutil

Which issue(s) this PR fixes:

Does this PR introduce a user-facing change?

None

other Note

@cndoit18
cleanup: io/ioutil
ae1f2a2 
Signed-off-by: cndoit18 <cndoit18@outlook.com>
@rambohe-ch
Copy link
Member

@cndoit18 Very appreciate for your work to upgrade io/ioutil. and based on https://go.dev/doc/go1.16#ioutil introduction, we need to replace io/ioutil with io or os library.

@cndoit18
Copy link
Member Author

@cndoit18 Very appreciate for your work to upgrade io/ioutil. and based on https://go.dev/doc/go1.16#ioutil introduction, we need to replace io/ioutil with io or os library.

Hi, Do I need to do anything else?

@rambohe-ch
Copy link
Member

@cndoit18 Very appreciate for your work to upgrade io/ioutil. and based on https://go.dev/doc/go1.16#ioutil introduction, we need to replace io/ioutil with io or os library.

Hi, Do I need to do anything else?

@cndoit18 no, and i will take a review and give you feedback.

@rambohe-ch
Copy link
Member

/lgtm

@openyurt-bot openyurt-bot added the approved approved label Apr 26, 2022
@rambohe-ch
Copy link
Member

/approve

@openyurt-bot openyurt-bot added the lgtm lgtm label Apr 26, 2022
@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cndoit18, rambohe-ch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openyurt-bot openyurt-bot merged commit 75fec1c into openyurtio:master Apr 26, 2022
@cndoit18 cndoit18 deleted the cleanup-ioutil branch April 26, 2022 08:48
JameKeal pushed a commit to JameKeal/openyurt that referenced this pull request May 16, 2022
@cndoit18 @JameKeal
cleanup: io/ioutil (openyurtio#813)
4e3a9b7 
Signed-off-by: cndoit18 <cndoit18@outlook.com>
openyurt-bot pushed a commit that referenced this pull request May 16, 2022
@JameKeal @Congrool
@cndoit18 @pengbinbin1 @MrGirl @rambohe-ch @lonelyCZ
【ADD】Uniform use processCreateErr func to create resource (#828)
536db52 
* add yurt-app-manager yurtappdaemon/yurtingress deploy and revert

* Revert "add yurt-app-manager yurtappdaemon/yurtingress deploy and revert"

This reverts commit ba28364.

* fix git safe dir error (#807)

Signed-off-by: Congrool <chpzhangyifei@zju.edu.cn>

* 【Optimize】unified image pull policy (#805)

* add yurt-app-manager yurtappdaemon/yurtingress deploy and revert

* Revert "add yurt-app-manager yurtappdaemon/yurtingress deploy and revert"

This reverts commit ba28364.

* unified image pull policy

* 【Optimize】optimize kubernetes util function (#808)

* add yurt-app-manager yurtappdaemon/yurtingress deploy and revert

* Revert "add yurt-app-manager yurtappdaemon/yurtingress deploy and revert"

This reverts commit ba28364.

* optimize kubernetes util func

* 【FIX】fix cloud node was heterogeneous (#806)

* add yurt-app-manager yurtappdaemon/yurtingress deploy and revert

* Revert "add yurt-app-manager yurtappdaemon/yurtingress deploy and revert"

This reverts commit ba28364.

* fix bug: when cloud node was heterogeneous, this parameter will be error

* cleanup: io/ioutil (#813)

Signed-off-by: cndoit18 <cndoit18@outlook.com>

* use constants instead the string (#814)

* ingress: update edge ingress proposal to add enhancement (#816)

* finish ut of sa token replacement (#787)

* finish ut of sa token replacement
add tenant sa token subsitute

* add tenant sa token subsitute

* add enable-node-pool parameter for yurthub in order to disable nodepools list/watch in filters when testing. (#822)

* Remove convert and revert command (#826)

Signed-off-by: lonelyCZ <531187475@qq.com>

* uniform processCreateErr func to deal the resource create

Co-authored-by: Yifei Zhang <chpzhangyifei@zju.edu.cn>
Co-authored-by: cndoit18 <cndoit18@outlook.com>
Co-authored-by: pengbinbin1 <pengbiny@163.com>
Co-authored-by: zzguang <zhengguang.zhang@intel.com>
Co-authored-by: MrGirl <wuyingxingzyd@163.com>
Co-authored-by: rambohe <linbo.hlb@alibaba-inc.com>
Co-authored-by: Zhe Cheng <47743202+lonelyCZ@users.noreply.github.com>
JameKeal pushed a commit to JameKeal/openyurt that referenced this pull request May 16, 2022
@cndoit18 @JameKeal
cleanup: io/ioutil (openyurtio#813)
945c18b 
Signed-off-by: cndoit18 <cndoit18@outlook.com>
JameKeal pushed a commit to JameKeal/openyurt that referenced this pull request May 16, 2022
@cndoit18 @JameKeal
cleanup: io/ioutil (openyurtio#813)
5fd47be 
Signed-off-by: cndoit18 <cndoit18@outlook.com>
@cndoit18 cndoit18 mentioned this pull request May 18, 2022
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rambohe-ch rambohe-ch rambohe-ch approved these changes

Assignees

@rambohe-ch rambohe-ch

Labels
approved approved lgtm lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cndoit18 @rambohe-ch @openyurt-bot