Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ingress: update edge ingress proposal to add enhancements #816

Merged
merged 1 commit into from
May 10, 2022
Merged

ingress: update edge ingress proposal to add enhancements #816

merged 1 commit into from
May 10, 2022

Conversation

zzguang
Copy link
Member

@zzguang zzguang commented Apr 30, 2022

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage
/sig storage

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

other Note

@openyurt-bot
Copy link
Collaborator

@zzguang: GitHub didn't allow me to assign the following users: your_reviewer.

Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage
/sig storage

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

other Note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openyurt-bot openyurt-bot added the size/M size/M: 30-99 label Apr 30, 2022
@zzguang
Copy link
Member Author

zzguang commented Apr 30, 2022

/assign @kadisi @rambohe-ch

@rambohe-ch
Copy link
Member

/lgtm

@openyurt-bot openyurt-bot added the lgtm lgtm label May 5, 2022
@rambohe-ch
Copy link
Member

@zzguang how about add some background and information about this enhacement?

@zzguang
Copy link
Member Author

zzguang commented May 5, 2022

@zzguang how about add some background and information about this enhacement?
okay, I will update it to add more info.

@openyurt-bot openyurt-bot removed the lgtm lgtm label May 5, 2022
@zzguang zzguang force-pushed the master branch 3 times, most recently from c2ba702 to da8c7b2 Compare May 5, 2022 07:03
@zzguang zzguang force-pushed the master branch 2 times, most recently from 7120e70 to 0dd73a2 Compare May 5, 2022 07:24
@kadisi
Copy link
Member

kadisi commented May 10, 2022

/lgtm
/approve

@openyurt-bot openyurt-bot added the lgtm lgtm label May 10, 2022
@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kadisi, zzguang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openyurt-bot openyurt-bot added the approved approved label May 10, 2022
@openyurt-bot openyurt-bot merged commit ff2cbe5 into openyurtio:master May 10, 2022
JameKeal pushed a commit to JameKeal/openyurt that referenced this pull request May 16, 2022
@JameKeal
ingress: update edge ingress proposal to add enhancement (openyurtio#816
36b34d0 
)
openyurt-bot pushed a commit that referenced this pull request May 16, 2022
@JameKeal @Congrool
@cndoit18 @pengbinbin1 @MrGirl @rambohe-ch @lonelyCZ
【ADD】Uniform use processCreateErr func to create resource (#828)
536db52 
* add yurt-app-manager yurtappdaemon/yurtingress deploy and revert

* Revert "add yurt-app-manager yurtappdaemon/yurtingress deploy and revert"

This reverts commit ba28364.

* fix git safe dir error (#807)

Signed-off-by: Congrool <chpzhangyifei@zju.edu.cn>

* 【Optimize】unified image pull policy (#805)

* add yurt-app-manager yurtappdaemon/yurtingress deploy and revert

* Revert "add yurt-app-manager yurtappdaemon/yurtingress deploy and revert"

This reverts commit ba28364.

* unified image pull policy

* 【Optimize】optimize kubernetes util function (#808)

* add yurt-app-manager yurtappdaemon/yurtingress deploy and revert

* Revert "add yurt-app-manager yurtappdaemon/yurtingress deploy and revert"

This reverts commit ba28364.

* optimize kubernetes util func

* 【FIX】fix cloud node was heterogeneous (#806)

* add yurt-app-manager yurtappdaemon/yurtingress deploy and revert

* Revert "add yurt-app-manager yurtappdaemon/yurtingress deploy and revert"

This reverts commit ba28364.

* fix bug: when cloud node was heterogeneous, this parameter will be error

* cleanup: io/ioutil (#813)

Signed-off-by: cndoit18 <cndoit18@outlook.com>

* use constants instead the string (#814)

* ingress: update edge ingress proposal to add enhancement (#816)

* finish ut of sa token replacement (#787)

* finish ut of sa token replacement
add tenant sa token subsitute

* add tenant sa token subsitute

* add enable-node-pool parameter for yurthub in order to disable nodepools list/watch in filters when testing. (#822)

* Remove convert and revert command (#826)

Signed-off-by: lonelyCZ <531187475@qq.com>

* uniform processCreateErr func to deal the resource create

Co-authored-by: Yifei Zhang <chpzhangyifei@zju.edu.cn>
Co-authored-by: cndoit18 <cndoit18@outlook.com>
Co-authored-by: pengbinbin1 <pengbiny@163.com>
Co-authored-by: zzguang <zhengguang.zhang@intel.com>
Co-authored-by: MrGirl <wuyingxingzyd@163.com>
Co-authored-by: rambohe <linbo.hlb@alibaba-inc.com>
Co-authored-by: Zhe Cheng <47743202+lonelyCZ@users.noreply.github.com>
JameKeal pushed a commit to JameKeal/openyurt that referenced this pull request May 16, 2022
@JameKeal
ingress: update edge ingress proposal to add enhancement (openyurtio#816
1638e5a 
)
JameKeal pushed a commit to JameKeal/openyurt that referenced this pull request May 16, 2022
@JameKeal
ingress: update edge ingress proposal to add enhancement (openyurtio#816
f6738e5 
)
@zzguang zzguang mentioned this pull request Jul 15, 2022
Closed
6 tasks
@zzguang zzguang mentioned this pull request Jul 25, 2022
Merged
6 tasks
@zzguang zzguang mentioned this pull request Dec 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Congrool Congrool Awaiting requested review from Congrool

@Fei-Guo Fei-Guo Awaiting requested review from Fei-Guo

Assignees

@kadisi kadisi

@rambohe-ch rambohe-ch

Labels
approved approved lgtm lgtm size/M size/M: 30-99
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zzguang @openyurt-bot @rambohe-ch @kadisi