Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add zzguang as approver of OpenYurt #913

Closed
wants to merge 0 commits into from
Closed

add zzguang as approver of OpenYurt #913

wants to merge 0 commits into from

Conversation

zzguang
Copy link
Member

@zzguang zzguang commented Jul 15, 2022 •
edited
Loading

GitHub Username

@zzguang

Organization you are requesting membership in

openyurtio

Sponsors

@kadisi

Requirements

  • I have joined in the community [Dingding] and [WeChat]
  • I often attend Openyurt Community Week
  • I have reviewed the [community membership docs]
  • I have spoken to my sponsors ahead of this application, and they have agreed to sponsor my application
  • I have checked my affiliation in [devstats] (if it's not correct, please fix in [cncf/gitdm])
  • I am actively contributing to 1 or more OpenYurt subprojects

List of your contributions

@openyurt-bot openyurt-bot added the size/XS size/XS: 0-9 label Jul 15, 2022
@kadisi
Copy link
Member

kadisi commented Jul 15, 2022

agree

@codecov
Copy link

codecov bot commented Jul 15, 2022 •
edited
Loading

Codecov Report

Merging #913 (de44106) into master (2d5938d) will decrease coverage by 0.07%.
The diff coverage is n/a.

❗ Current head de44106 differs from pull request most recent head 2debc11. Consider uploading reports for the commit 2debc11 to get more accurate results

@@            Coverage Diff             @@
##           master     #913      +/-   ##
==========================================
- Coverage   35.37%   35.30%   -0.08%     
==========================================
  Files          76       76              
  Lines        9913     9913              
==========================================
- Hits         3507     3500       -7     
- Misses       6141     6146       +5     
- Partials      265      267       +2
Flag Coverage Δ
unittests 35.30% <ø> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/yurthub/filter/masterservice/handler.go 65.07% <0.00%> (-11.12%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us.

@rambohe-ch
Copy link
Member

@zzguang welcome you to apply community approver. agree +1

@gnunu
Copy link
Member

gnunu commented Jul 15, 2022

agree +1
:)

@zzguang zzguang closed this Jul 25, 2022
@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zzguang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openyurt-bot openyurt-bot added the approved approved label Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charleszheng44 charleszheng44 Awaiting requested review from charleszheng44

@kadisi kadisi Awaiting requested review from kadisi

Assignees
No one assigned
Labels
approved approved size/XS size/XS: 0-9
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zzguang @kadisi @rambohe-ch @gnunu @openyurt-bot