Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump @primer/css by add more dependency #16991

Merged
merged 1 commit into from
Oct 21, 2024
Merged

Bump @primer/css by add more dependency #16991

merged 1 commit into from
Oct 21, 2024

Conversation

Eric-Guo
Copy link
Contributor

What are you trying to accomplish?

Make sure new @primer/css continue work in OP

What approach did you choose and why?

Add removed dependency in @primer/css in package.json

Merge checklist

  • Added/updated tests
  • Added/updated documentation in Lookbook (patterns, previews, etc)
  • Tested major browsers (Chrome, Firefox, Edge, ...)

@ulferts ulferts requested a review from HDinger October 21, 2024 07:17
@Eric-Guo
Copy link
Contributor Author

@ulferts it will fix #16997

@ulferts
Copy link
Contributor

ulferts commented Oct 21, 2024

I get that @Eric-Guo , I just think that @HDinger can better judge the quality of the fix.

HDinger
HDinger approved these changes Oct 21, 2024
View reviewed changes
Copy link
Contributor

@HDinger HDinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks @Eric-Guo 🙇 👍

@HDinger HDinger merged commit c6aa3ae into opf:dev Oct 21, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HDinger HDinger HDinger approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Eric-Guo @ulferts @HDinger