Move prod @primer/* dependencies to dev #2724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 917fd93 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
camertron
temporarily deployed
to
github-pages
GitHub Actions
Inactive
jonrohan
reviewed
Oct 18, 2024
jonrohan
approved these changes
Oct 18, 2024
Merged
Eric-Guo
added a commit
to Eric-Guo/openproject
that referenced
this pull request
Oct 21, 2024
…/view-components (custom by op)
3 tasks
Eric-Guo
added a commit
to Eric-Guo/openproject
that referenced
this pull request
Oct 21, 2024
…/view-components (custom by op)
Eric-Guo
added a commit
to Eric-Guo/openproject
that referenced
this pull request
Oct 21, 2024
…/view-components (custom by op)
Eric-Guo
added a commit
to Eric-Guo/openproject
that referenced
this pull request
Oct 21, 2024
…/view-components (custom by op)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
Both primer/view-components and primer/primitives are only used during build and therefore do not need to be listed as prod dependencies. Since primer/css is not updated very often anymore, leaving these two packages as prod dependencies is causing conflicts in other projects that use newer versions.
What approach did you choose and why?
I moved primer/view-components and primer/behaviors to
devDependenciesin the package.json.Can these changes ship as is?