-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tranquilo cleanup #443
Tranquilo cleanup #443
Conversation
Codecov Report
@@ Coverage Diff @@
## main #443 +/- ##
==========================================
+ Coverage 92.86% 92.98% +0.12%
==========================================
Files 244 248 +4
Lines 18497 18526 +29
==========================================
+ Hits 17177 17227 +50
+ Misses 1320 1299 -21
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few small comments but I already approve.
In this PR, we clean up certain components of tranquilo:
bounds.py
for theBounds
dataclass.region.py
for theRegion
dataclassmap_to_unit
andmap_from_unit
for transitioning between the unit space used in points sampling, fitting, and solving the subproblem, and the regular trustregion space.ModelInfo
with the stringmodel_type
which can only be eitherlinear
orquadratic
.