Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use true-case-path to fix re-entrancy issue on Windows and Webpack #851

Closed
wants to merge 1 commit into from

Conversation

amilajack
Copy link

This issue is a fix for #818. This issue is similar to sass/node-sass#2149, which

When using node-sass through multiple entry points (as can happen when using webpack) on Windows, the casing of the drive letter in the path can be inconsistent. Since Node is case-sensitive to a fault, this results in Node attempting to create a second instance of the native binding, which results in a Module did not self-register error.

The fix is to use true-case-path to normalize the binding path, to prevent unintended duplicate bindings from occurring.

@cjbj
Copy link
Member

cjbj commented Feb 16, 2018

I appreciate you doing this but

  • you didn't sign the OCA before submitting

  • I really don't want 3rd party code included for legal & security reasons.

@amilajack
Copy link
Author

amilajack commented Feb 16, 2018

I have followed the directions here for the OCA. I submitted mine a few minutes ago. Does it take time to process?

Edit: Fixed it

Signed-off-by: Amila Welihinda <amilajack@github.com>
@cjbj
Copy link
Member

cjbj commented Apr 3, 2018

I've no plans to merge this because it injects 3rd party code into the install - a security issue. I'd be happy to merge a PR that directly patched node-oracledb code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants