Build error with electron on windows environment

[lealhugui]

I'm trying to build a electron bundled app that uses oracledb connections.
No problem with the instalation or the use on "pure node" mode. But when I try to rebuild the dependency tree with electron-rebuild (mainly because I use other libs that need node-ffi) I get a build error on oracledb headers.

1. What is your Node.js version?
   Run at: Mon Feb 26 2018 17:31:45 GMT-0300
   Node.js version: v8.9.3 (win32 x64)
   Node-oracledb version: 2.1.2
   Oracle Client library version: 12.2.0.1.0

2. What is your node-oracledb version?
   2.1.1

3. What is your Oracle client (e.g. Instant Client) version? Is it 64-bit or 32-bit? How was it installed? Where is it installed?
   InstantClient 12.2, 64Bit on windows, installed from zip on C:\instantclient_12_2_64.

4. What is your Oracle Database version?
   Not relevant for this issue.

5. What is your OS and version?
   Windows 10

6. What is your compiler version? For example, with GCC, run gcc --version
   MSBuild 14.0

7. What Oracle environment variables did you set? How exactly did you set them?
   Only isntant client on path: C:\instantclient_12_2_64.

8. What is the PATH environment variable (on Windows) or LD_LIBRARY_PATH (on Linux) set to? On macOS, what is in ~/lib?
   C:\instantclient_12_2_64.

9. What error(s) you are seeing?
   On gist: Oracledb error on electron-rebuild

[cjbj]

Is the right version of NAN installed?

Stepping back a bit, are you able to use the pre-built binaries?

[lealhugui]

@cjbj

Is the right version of NAN installed?

NAN is a dep of oracledb? Should I install it through NPM?

Stepping back a bit, are you able to use the pre-built binaries?

If I run the app without electron environment, the binaries work just fine (was able to connect and query on different databases)

[cjbj]

@lealhugui what's the version of NAN that is being used? Can you work out why there is even a build being kicked off - the normal 'npm install oracledb' can't fallback to building. Have you updated electron?

[lealhugui]

@cjbj
NAN version is 2.8.0 (already tested on 2.7 and 2.9 too)
The trigger for the build is a manual call for "electron-rebuild", wich is needed (almost) each time a new dep is added.

[cjbj]

How have you set the dependency for oracledb? Why isn't the package.json 'install' script target being executed (to download a pre-built binary)?

[lealhugui]

The dependency was a added through a npm install, and that went just fine.

[cjbj]

Can you explain more so I can try to help? What install options?

[lealhugui]

The error doesn't occurr during the instalation of the module.

The module is installed correctly, and works fine while the app is executed outside electron environment.
The problem occurs if I try to rebuild the app to bundle with electron; for that, I use electron-rebuild (because the app have some native modules), and is during the execution of electron-rebuild, that the build of node-oracledb fails, throwing the above mentioned error stack.

[cjbj]

That's too generic; I can't offer any new guesses. Can you share exact details about what you are entering where, and the commands you are running?

Other people seem to be use Electron without an issue.

[lealhugui]

Yes I Can.
Just created a clean repo that reproduce the error.
Clone, npm install, and run the electron-rebuild rebuild command, and you should see the error (the full step-by-step is in the repo readme).

[cjbj]

Maybe electron or something is ignoring the install script in package.json. Try creating your own oracledb bundle without the binding.gyp file and using that as a target in your package.json.

[lealhugui]

Can you tell me how to do that?

[cjbj]

1. To create your own npm packages you can do:

   • download a ZIP or clone the source code of node-oracledb

   • remove binding.gyp

   • run 'npm pack'

   • use something similar to this in your config file:

   "dependencies": {
   "oracledb" : "file:/Users/cjones/oracledb-2.1.2-dev.tgz"
   },

2. Regarding your testcase, I ran this on macOS:
   ./node_modules/.bin/electron-rebuild rebuild --target=1.8.2 --runtime=electron
   and it finished with:
   ✔ Rebuild Complete

[lealhugui]

My environment is windows, so that must be the real differnce.
Will try the custom package aproach, and as soon as I get some conclusion, I report back.

[lealhugui]

@cjbj
2 situations:

1. Downloaded the ZIP of the source, removed binding.gyp, and installed. That way I was able to correctly run electron-rebuild, but when I try to require the oracle module/open connection, I get Error: NJS-045: cannot load the oracledb add-on binary for Node.js 7.9.0 (win32, x64). I noticed that because I dont have binding.gyp BEFORE the npm install, it doesn't execute the build step on the install and dont create the ./node_modules/oracledb/build/* subfolders;

2. Installed from npm default repository (npm install oracledb --save) , and after the install, removed binding.gyp. It makes the electron-rebuild pass, but when I try to require the oracledb module/open connection, I get:
   Cannot load C:\myproj\node_modules\oracledb\build\Release\oracledb.node A dynamic link library (DLL) initialization routine failed. \\?\C:\myproj\node_modules\oracledb\build\Release\oracledb.node

[cjbj]

It seems in your case the package.json install script target isn't being invoked. I don't have more guesses on why. I assume the target was invoked for me when I tried your testcase, since your testcase didn't fail for me.

Got another platform you can test on? A different environment e.g. with or without globally installed modules?

[lealhugui]

Yes. Same project on a macOS works. Unfortunately, need to cover macOS, Linux, and Windows. The problem appears specialy on windows. Em qui, 8 de mar de 2018 às 18:06, Christopher Jones < notifications@github.com> escreveu:

It seems in your case the package.json install script target isn't being invoked. I don't have more guesses on why. I assume the target was invoked for me when I tried your testcase, since your testcase didn't fail for me. Got another platform you can test on? A different environment e.g. with or without globally installed modules? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#862 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACjaTZjU2BveE_0GZqQJHkDYWwqo59M6ks5tcZ1tgaJpZM4ST4Tq> .

-- Guilherme Leal

[cjbj]

@kwent did you face something similar with electron on Windows?

[kwent]

@lealhugui Could you try using that PR ? #851

[lealhugui]

Will try tomorrow

[lealhugui]

Got an error during npm install. Pasted on this gist

[kwent]

@lealhugui you need to clone using --recursive to include submodules.

git clone --recursive git://github.com/username/repository.git

[anthony-tuininga]

The other option (if you've already cloned) is to run these commands in the directory you cloned:

git submodule init
git submodule update

[lealhugui]

@kwent Same error as initial report.
https://gist.github.com/lealhugui/9687dfa2ed43d9a6e08798f6dca36341

[lealhugui]

@cjbj @kwent
Any new ideas?

[cjbj]

@lealhugui not from me, sorry.

[cjbj]

Closing - no activity.