-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Haro Strait vs Straight #145
Comments
Since there are already two hydrophone monitoring sites in Haro Strait, another underdevelopment on the Canadian side, and Orcasound plans for another 1-2, I'd 2nd Dave's suggestion to standardize by switching to the "Orcasound Lab" label. For future-proofing, it would be ideal for the Moderator Portal and other apps using the Swagger API to all utilize the Orcasound API for assigning labels when a new node is integrated in the OrcaHello real time inference system. |
I feel like the proper fix is to use some kind of unique ID (ex: GUID) for each site and have a single mapping from ID to location string. That would make updates easier in case we decided to rename the location (ex: Haro Strait 1/2/3 or some other more descriptive naming). |
I agree that using a unique ID internally is important, but it's also important to use a consistent display name across sites. Currently https://live.orcasound.net/api/json/feeds has multiple identifiers it provides:
"id" is, I believe, the unique ID for the hydrophone. "name" is a display name and could be renamed. "node_name" is a path component used in constructing the S3 path. In theory it could be changed but then one would either have broken URIs or one would have to enable redirects. "slug" is a path component used in constructing the orcasound.net path. In theory it could be changed but then one would either have broken URIs or one would have to enable redirects. |
There's also a unique ID on dataplicity that is a GUID: I am not sure why orcasound.net doesn't expose it and instead exposes some other "id". |
That Let me know if you'd like either of those changes! |
I think exposing the dataplicity "serial" value would be helpful. |
Fixes orcasound#145 Signed-off-by: Dave Thaler <dthaler1968@gmail.com>
Fixes orcasound#145 Signed-off-by: Dave Thaler <dthaler1968@gmail.com>
Fixes orcasound#145 Signed-off-by: Dave Thaler <dthaler1968@gmail.com>
Great question, so far projects have grown organically and we haven't really formalized a source of truth / data schema for hydrophone node/feed/location metadata. It's something to figure out as more projects spring up. For the time being, I agree that orcasite (https://live.orcasound.net) is the de facto source of truth. As a primary ID, I would rather rely on our internal ID ( The other identifiers seem less stable:
|
https://aifororcasdetections.azurewebsites.net/swagger/index.html and various other files show "Straight" whereas the actual name is "Strait". (And neither of them match the live.orcasound.net name for it of "Orcasound Lab".)
The text was updated successfully, but these errors were encountered: