Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Haro Strait/Straight to Orcasound Lab #153

Merged
merged 2 commits into from
Sep 16, 2024

Conversation

dthaler
Copy link
Collaborator

@dthaler dthaler commented Jul 26, 2024

  • Rename Haro Strait/Straight to Orcasound Lab
  • Add additional nodes that were missing from the combobox to select from

Fixes #145
Fixes #146

This is a temporary workaround. The correct fix is to get the full list from live.orcasound.net/api/json/feeds

Fixes orcasound#145

Signed-off-by: Dave Thaler <dthaler1968@gmail.com>
Fixes orcasound#146

Signed-off-by: Dave Thaler <dthaler1968@gmail.com>
@dthaler dthaler requested a review from micowan July 31, 2024 03:57
@dthaler
Copy link
Collaborator Author

dthaler commented Sep 4, 2024

@micowan what is the next step needed for this PR?

@veirs veirs merged commit 7d2ba72 into orcasound:main Sep 16, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sunset Bay doesn't appear in the filter selection Haro Strait vs Straight
2 participants