Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add teleburn command #1680

Merged
merged 19 commits into from
Oct 23, 2023
Merged

Add teleburn command #1680

merged 19 commits into from
Oct 23, 2023

Conversation

casey
Copy link
Collaborator

@casey casey commented Feb 11, 2023

People are interested in burning high-value Ethereum NFTs, so this feature needs to be extremely safe:

  • add tests
  • review cryptographic assumptions

  • generate ethereum address with checksum (no ethereum dependencies for this, must be implemented manually)
  • manual end-to-end test (we can just make sure that you can derive genesis inscription ID from the ethereum address)
  • make sure that the index is synced and that the inscription that you're burning is in your wallet
  • add ability to reverse teleburn: get the inscription id from the teleburn address
  • show teleburn address on inscription page
  • only accept ethereum addresses with checksum when deserializing

@Rob1Ham
Copy link

Rob1Ham commented Feb 11, 2023

I'll do a couple tests to verify this works.

@casey
Copy link
Collaborator Author

casey commented Feb 12, 2023

Is length extension an issue?

@rot13maxi
Copy link
Contributor

No, it shouldn't be

@rot13maxi
Copy link
Contributor

knocked out a few of your checklist items in #1825

@rot13maxi
Copy link
Contributor

rot13maxi commented Feb 24, 2023

The reverse lookup is an interesting feature. On the one hand, it would be super cool to let anyone search for an eth address and find the inscription that it was teleburned to. On the other hand, I'm pretty sure the only way to do that efficiently is to keep an index that maps teleburn address to inscription ID for every inscription. I started hacking that up here:
rot13maxi/ord@master...rot13maxi:ord:teleburn

I'm new to redb, so there might be a better way to do it, but the tl;dr is that we add an entry to a simple str->InscriptionId table when we update the index. I haven't profiled it yet to see what the perf hit is, but from some really ad-hoc testing on signet, its seems non-trivial...

@raphjaph raphjaph mentioned this pull request Jun 9, 2023
@rot13maxi
Copy link
Contributor

hey @raphjaph and @casey what else are you looking for in this?

@raphjaph raphjaph marked this pull request as ready for review October 22, 2023 18:10
Copy link
Collaborator

@raphjaph raphjaph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let it burn!

@casey casey enabled auto-merge (squash) October 23, 2023 02:26
@casey casey merged commit 676c212 into master Oct 23, 2023
6 checks passed
@casey casey deleted the teleburn branch October 23, 2023 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants