-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add teleburn command #1680
Add teleburn command #1680
Conversation
I'll do a couple tests to verify this works. |
Is length extension an issue? |
No, it shouldn't be |
knocked out a few of your checklist items in #1825 |
The reverse lookup is an interesting feature. On the one hand, it would be super cool to let anyone search for an eth address and find the inscription that it was teleburned to. On the other hand, I'm pretty sure the only way to do that efficiently is to keep an index that maps teleburn address to inscription ID for every inscription. I started hacking that up here: I'm new to redb, so there might be a better way to do it, but the tl;dr is that we add an entry to a simple str->InscriptionId table when we update the index. I haven't profiled it yet to see what the perf hit is, but from some really ad-hoc testing on signet, its seems non-trivial... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let it burn!
People are interested in burning high-value Ethereum NFTs, so this feature needs to be extremely safe: