Added checksum to eth address, added teleburn to inscriptions page #1825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks pretty fun! |
cbspears
reviewed
Feb 23, 2023
| @@ -10,35 +11,10 @@ pub struct Output { | |||
| ethereum: EthereumTeleburnAddress, | |||
| } | |||
|
|
|||
| #[derive(Debug, PartialEq)] | |||
There was a problem hiding this comment.
Review ACK
This reviews suggested changes are to "plz ignore" and that is what I do with code reviews anyways.
cryptoquick
reviewed
May 25, 2023
| fn from(inscription_id: InscriptionId) -> Self { | ||
| let digest = bitcoin::hashes::sha256::Hash::hash(&inscription_id.store()); | ||
| Self { | ||
| address: create_address_with_checksum(&digest[0..20].to_hex()), |
There was a problem hiding this comment.
Wouldn't it make more sense to just use md160 as the hash function here? It's the same one that hashes public keys in P2WPKH addresses, and it also produces 20 bytes.
There was a problem hiding this comment.
There’s an implementation that @casey and rob did thats already been used to teleburn some NFTs, so i stuck with this to not invalidate that burn
There was a problem hiding this comment.
Gotcha, well, this works too!
raphjaph
approved these changes
Jun 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR: