Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix remote RPC wallet commands #1766

Merged
merged 8 commits into from
Jul 28, 2023

Conversation

carlosalaniz
Copy link
Contributor

https://discord.com/channels/987504378242007100/1074458232094994532/1074458232094994532

Original post;

Osvaldrinks
OP
— 02/12/2023 4:33 PM
I have ord 0.5.0 installed on my laptop and use the --cookie-file and --rpc-url flags to connect to my raspberry pi node on my local network.

I can run $ ord --cookie-file ./.cookie --rpc-url 192.168.1.115 index and start indexind the blocks. That is my local ord talks to my node on my local network.

The problem
I am running the
$ ord --cookie-file ./.cookie --rpc-url 192.168.1.115 wallet create
and get this error
error: JSON-RPC error: RPC error response: RpcError { code: -19, message: "Wallet file not specified (must request wallet RPC through /wallet/ uri-path).", data: None }

I go an check my node bitcoin directory and see that the ord wallet was created but no mnemonic or anything but the error above.
I go ahead and run the same command again and get a DIFFERENT ERROR
ord --cookie-file ./.cookie --rpc-url 192.168.1.115 wallet create
error: JSON-RPC error: RPC error response: RpcError { code: -4, message: "Wallet file verification failed. Failed to create database path '/home/bitcoin/.bitcoin/ord'. Database already exists.", data: None }

It is important to note that all of this is being done while the $ ord --cookie-file ./.cookie --rpc-url 192.168.1.115 index command is running and the indexing has not finished

@casey casey added the bug label Mar 3, 2023
Copy link
Collaborator

@raphjaph raphjaph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good bug fix! Sorry for just now looking at this.

@raphjaph raphjaph enabled auto-merge (squash) July 28, 2023 15:15
@raphjaph raphjaph merged commit 97804d1 into ordinals:master Jul 28, 2023
sidmorizon added a commit to OneKeyHQ/ord that referenced this pull request Aug 1, 2023
* Add contributing section (ordinals#2261)

* Implement clean index shutdown to prevent index corruption (with clippy updates for Rust 1.71) (ordinals#2275)

* gracefully shutdown index update thread to prevent index corruption

* Use `next_back()` instead of `rev().next()` for rust 1.71

---------

Co-authored-by: victorkirov <victor.kirov@gmail.com>

* Modify `ord list` output to include the end of each range (ordinals#1998)

* Don't create default data directory if --index overrides it (ordinals#1991)

* Fix docs inconsistency (ordinals#2276)

* Fix ordering for reinscriptions and show all reinscriptions for sat (ordinals#2279)

* Add satpoint and address to index export (ordinals#2284)

* Update bitcoin dependencies (ordinals#2281)

* Update redb (ordinals#2294)

* Add retry to fetcher (ordinals#2297)

* Clean up deploy scripts (ordinals#2298)

* Fix justfile recipe (ordinals#2299)

* Release 0.8.1 (ordinals#2300)

* Add `amount` field to `wallet inscriptions` output. (ordinals#1928)

* Fix dust limit for padding in `TransactionBuilder` (ordinals#1929)

* Inform user when redb starts in recovery mode (ordinals#2304)

* Fix remote RPC wallet commands (ordinals#1766)

* Select multiple utxos (ordinals#2303)

Co-authored-by: Greg Martin <gm7t2@gmail.com>

* feat: add outputs api

---------

Co-authored-by: raph <raphjaph@protonmail.com>
Co-authored-by: victorkirov <victor.kirov@gmail.com>
Co-authored-by: gmart7t2 <49558347+gmart7t2@users.noreply.github.com>
Co-authored-by: ordinally <11798624+veryordinally@users.noreply.github.com>
Co-authored-by: Carlos Alaniz <carlosglvn93@gmail.com>
Co-authored-by: Greg Martin <gm7t2@gmail.com>
Raylin51 pushed a commit to 0xaklabs/ord that referenced this pull request Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants