Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select multiple utxos #2303

Merged
merged 12 commits into from
Jul 30, 2023
Merged

Conversation

raphjaph
Copy link
Collaborator

Duplicate of #1858 but have to make some small changes and cannot edit PR there.

@raphjaph
Copy link
Collaborator Author

@gmart7t2 I added the --max-inputs to the fuzz tester and let it run for a day. Didn't produce any panics. I also made the select_cardinal_utxo logic more verbose so it is easier to understand. If my that change doesn't fit the logic you meant let me know. All tests seem to pass though.

@gmart7t2
Copy link
Contributor

I've never used --max-inputs

I added it because of a comment in the PR from someone who was concerned that selecting multiple utxos might select too many of them.

Personally I don't mind if you remove the --max- inputs flag completely

@raphjaph
Copy link
Collaborator Author

Ok I will remove it then

@raphjaph raphjaph enabled auto-merge (squash) July 30, 2023 15:26
@raphjaph raphjaph merged commit 2c03829 into ordinals:master Jul 30, 2023
sidmorizon added a commit to OneKeyHQ/ord that referenced this pull request Aug 1, 2023
* Add contributing section (ordinals#2261)

* Implement clean index shutdown to prevent index corruption (with clippy updates for Rust 1.71) (ordinals#2275)

* gracefully shutdown index update thread to prevent index corruption

* Use `next_back()` instead of `rev().next()` for rust 1.71

---------

Co-authored-by: victorkirov <victor.kirov@gmail.com>

* Modify `ord list` output to include the end of each range (ordinals#1998)

* Don't create default data directory if --index overrides it (ordinals#1991)

* Fix docs inconsistency (ordinals#2276)

* Fix ordering for reinscriptions and show all reinscriptions for sat (ordinals#2279)

* Add satpoint and address to index export (ordinals#2284)

* Update bitcoin dependencies (ordinals#2281)

* Update redb (ordinals#2294)

* Add retry to fetcher (ordinals#2297)

* Clean up deploy scripts (ordinals#2298)

* Fix justfile recipe (ordinals#2299)

* Release 0.8.1 (ordinals#2300)

* Add `amount` field to `wallet inscriptions` output. (ordinals#1928)

* Fix dust limit for padding in `TransactionBuilder` (ordinals#1929)

* Inform user when redb starts in recovery mode (ordinals#2304)

* Fix remote RPC wallet commands (ordinals#1766)

* Select multiple utxos (ordinals#2303)

Co-authored-by: Greg Martin <gm7t2@gmail.com>

* feat: add outputs api

---------

Co-authored-by: raph <raphjaph@protonmail.com>
Co-authored-by: victorkirov <victor.kirov@gmail.com>
Co-authored-by: gmart7t2 <49558347+gmart7t2@users.noreply.github.com>
Co-authored-by: ordinally <11798624+veryordinally@users.noreply.github.com>
Co-authored-by: Carlos Alaniz <carlosglvn93@gmail.com>
Co-authored-by: Greg Martin <gm7t2@gmail.com>
Raylin51 pushed a commit to 0xaklabs/ord that referenced this pull request Aug 11, 2023
Co-authored-by: Greg Martin <gm7t2@gmail.com>
@raphjaph raphjaph deleted the select-multiple-utxos branch January 31, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants