Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GITBOOK: Jinglee's May 30 changes Handbook_CHN Version 1.0 #2128

Closed
wants to merge 2 commits into from
Closed

GITBOOK: Jinglee's May 30 changes Handbook_CHN Version 1.0 #2128

wants to merge 2 commits into from

Conversation

DrJingLee
Copy link
Contributor

Updated to 5-30 with the new donation address.

@raphjaph
Copy link
Collaborator

Thanks for translating! Would be great to have this as part of the normal docs, which are made with mdBook. In order to do that we would probably have to use https://github.com/google/mdbook-i18n-helpers. Unfortunately I do not have time to do that at the moment but happy to review the PR when it's done.

@DrJingLee
Copy link
Contributor Author

DrJingLee commented May 30, 2023

Thanks for translating! Would be great to have this as part of the normal docs, which are made with mdBook. In order to do that we would probably have to use https://github.com/google/mdbook-i18n-helpers. Unfortunately I do not have time to do that at the moment but happy to review the PR when it's done.

Thanks Raphjaph for the response. Let me try to learn how to use mdBook.

See new PR #2350

@veryordinally
Copy link
Collaborator

@DrJingLee since we're getting more PRs with translations now with the OMB bounties, I was checking the status of your PR for the Chinese translation. Is there a more recent one, or what was the reason for closing? We should make sure all translations follow a common pattern.

@DrJingLee
Copy link
Contributor Author

DrJingLee commented Aug 25, 2023

Yes ser @veryordinally ,I have submitted a new PR 2350 with the mdbook format. So I close this pr and open the following pr #2350

#2350 (comment)

@DrJingLee since we're getting more PRs with translations now with the OMB bounties, I was checking the status of your PR for the Chinese translation. Is there a more recent one, or what was the reason for closing? We should make sure all translations follow a common pattern.

@DrJingLee DrJingLee mentioned this pull request Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants