Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ordinal handbook arabic version #2362

Closed
wants to merge 0 commits into from
Closed

Conversation

ordinaHO
Copy link
Contributor

No description provided.

@ordinaHO ordinaHO changed the title Update introduction.md new links add ordinal handbook arabic version Aug 24, 2023
@veryordinally
Copy link
Collaborator

Clippy tests seem to fail.
Need to work out structure for adding new languages. See for example #2128 for another example (Chinese).

@DrJingLee
Copy link
Contributor

Seems CI / lint (pull_request) is failed.
The error says on the line 29 of "tests/parse.rs", the # is not nessessary :

.stderr_regex(r#"error: .: unrecognized object\n."#)

ChatGPT Advice to revise to but i have no idea:

.stderr_regex(r"error: .: unrecognized object\n.")

@DrJingLee
Copy link
Contributor

Clippy tests seem to fail. Need to work out structure for adding new languages. See for example #2128 for another example (Chinese).

Exactly. I try to merge the handbook by creating a new sub-folder called "chn" under "docs" ,the url will be docs.ordinals.com/chn.and "chn" have the same structure with the "docs" files.

We might need to revise the index of urls to link different version of handbook translations.

Does this workable ? @veryordinally @raphjaph

@ordinaHO
Copy link
Contributor Author

Seems CI / lint (pull_request) is failed. The error says on the line 29 of "tests/parse.rs", the # is not nessessary :

.stderr_regex(r#"error: .: unrecognized object\n."#)

ChatGPT Advice to revise to but i have no idea:

.stderr_regex(r"error: .: unrecognized object\n.")

Yep i think i worked my way out of this , installed nodejs markdown lint aswell and i was able to scan my errors and now should be ok 👌

@ordinaHO
Copy link
Contributor Author

i think that what should be updated into the new bool.toml to run the new version on ordinals.com ! for now im using my local server to check if all the changes im making is in the correct form i need .

@veryordinally
Copy link
Collaborator

veryordinally commented Aug 26, 2023

OK, confirm that the remaining clippy issue is due to new rust release and unrelated to this PR.

@raphjaph
Copy link
Collaborator

If someone could implement this first: #2385 that would be awesome!

@ordinaHO
Copy link
Contributor Author

Hi raph , i took a look about the plugins i thinnk it for translation of documentation written in mdbook into multiple languages. Is that what are you referring ? im not sure if there is Arabic as i went through the book almost each word and the most hard part is that arabic writing is from right to left and a lot of words cant just be automatically translated.
Both ways will follow up on this so we can figure the best way so all incoming requests will have one commen steps to do .
best regards

@raphjaph
Copy link
Collaborator

I just merged #2403, so have a look at the updated README for instructions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants