Add router Runes balance and format Tx response to JSON #2978

lugondev · 2024-01-07T06:17:46Z

Formatting response /tx/{tx_id} into JSON
Add router /runes/balance to fetch all runes balance

lugondev · 2024-01-07T06:29:28Z

@casey @raphjaph I want to bring more the functions from commands to server routes to make it easier for UI access and development.

Following: #2936

raphjaph

Looks good so far!

Could you add tests for both endpoints in tests/json_api.rs?

src/subcommand/server.rs

lugondev · 2024-01-09T02:55:57Z

Ok, I will do it

lugondev · 2024-01-28T07:44:45Z

hi @raphjaph, it's been a long time. I have just added tests for the router, all tests were passed in my local but had a failure tests in CI.
give me any feedback
thanks!

raphjaph

Just some minor things.

I'm also thinking we should probably also add an HTML page for this. If you have a good idea how to display this let me know. Probably some <dl>/<dt> list.

src/subcommand/server.rs

Co-authored-by: raph <raphjaph@protonmail.com>

lugondev · 2024-01-29T05:08:28Z

Just some minor things.

I'm also thinking we should probably also add an HTML page for this. If you have a good idea how to display this let me know. Probably some <dl>/<dt> list.

yeah, will I do it in next pull request?

lugondev · 2024-01-29T05:10:50Z

Just some minor things.
I'm also thinking we should probably also add an HTML page for this. If you have a good idea how to display this let me know. Probably some <dl>/<dt> list.

yeah, will I do it in next pull request?

I would like to use this endpoint for my product with the official repo ord. Thank you for understanding.

lugondev · 2024-01-30T10:52:56Z

@raphjaph help me check this pull request

raphjaph

LGTM!

Just fixed some small things here and there

lugondev · 2024-01-31T04:55:57Z

LGTM!

Just fixed some small things here and there

thanks you so much

casey

Looks good @lugondev, amazing work!

* master: Use a flag to indicate a mint (ordinals#3068) Add dry run to send, print Outgoing and PSBT (ordinals#3063) Make invariant message more concise (ordinals#3029) Add /runes/balances (ordinals#2978)

* Add recipe to deploy to all servers in fleet (ordinals#2992) * Suppress empty command output (ordinals#2995) * Optimize get_inscription_ids_by_sat_paginated (ordinals#2996) * Add crate to audit content security policy (ordinals#2993) * Remove dead link from README (ordinals#3000) * Add `indexed` to output JSON (ordinals#2971) * Cache less aggressively (ordinals#3002) * Add minimal Dockerfile (ordinals#2786) * Don't use browser sniffing when serving favicon (ordinals#3003) * Add option to retain sat index for spent outputs (ordinals#2999) * Hide BVM Network inscriptions (ordinals#3012) * Use --name instead of --wallet in README (ordinals#3010) * Add blocks and transaction JSON endpoints (ordinals#3004) * Inscribe with delegate (ordinals#3021) * Use untyped table API to get table info (ordinals#2747) * Make wallet communicate with index via RPC (ordinals#2929) * Break deploy recipes into multiple lines (ordinals#3026) * Test fee-spent inscription numbering (ordinals#3032) * Remove uneccessary allocations in Inscription Script Creation (ordinals#3039) * Better wallet error messages (ordinals#3041) * Add documentation for reinscriptions (ordinals#2963) * Exclude unnecessary docs (ordinals#3043) * Enable JSON API by default (ordinals#3047) * Forbid destinations in same-sat mode (ordinals#3038) * Dump and restore wallet from descriptors (ordinals#3048) * Add /runes/balances (ordinals#2978) * Make invariant message more concise (ordinals#3029) * Add dry run to send, print Outgoing and PSBT (ordinals#3063) * Use a flag to indicate a mint (ordinals#3068) * Move SatPoint into library (ordinals#3077) * [ordinals] Bump version: 0.0.1 → 0.0.2 (ordinals#3078) * Use min instead of clamp (ordinals#3081) * Make clippy stop complaining about insane repair callback (ordinals#3104) * Remove index parameter from index_block (ordinals#3088) * Allow specifying satpoint in `same-sat` batch inscribe (ordinals#3100) * Show reinscriptions in `ord wallet inscriptions` (ordinals#3101) * Move sat and friends into ordinals crate (ordinals#3079) * fix naming (ordinals#3112) * Return signed PSBT from `ord wallet send` (ordinals#3093) * Add /r/blockinfo endpoint (ordinals#3075) * Import multiple descriptors at a time (ordinals#3091) * Add `satpoints` batch inscribe mode (ordinals#3115) * Allow inscribing AVIF images (ordinals#3123) * Fix spelling mistake in bip.mediawiki (ordinals#3118) * Only allow mnemonic from stdin (ordinals#3023) * Emit inscription update events to channel (ordinals#3137) * Make Options public (ordinals#3138) * Use `image-rendering: auto` when downscaling images (ordinals#3144) * Add `ord env` to spin up a test bitcoin daemon and ord server (ordinals#3146) * Display inscription content type counts on /status (ordinals#3127) * Add optional HTTP authentication for server (ordinals#3131) * Make wallet async (ordinals#3142) * Add `/r/inscription` endpoint for getting inscription details (ordinals#2628) * Use `image-rendering: auto` for AVIF inscriptions (ordinals#3148) * Make `ord env` more user friendly (ordinals#3153) * Move JSON structs into api module (ordinals#3167) * Display parent above metadata on /inscription (ordinals#3160) * Represent rune IDs as `BLOCK:TX` (ordinals#3165) * Add parent preview to inscription page (ordinals#3163) * Update inscription sat documentation (ordinals#3114) * Fix lints (ordinals#3124) * Remove unnecessary lifetime from Formatter (ordinals#3178) * Print PSBT for dry run inscribe (ordinals#3116) * Update docs to reflect wallet changes (ordinals#3179) * Improve configuration (ordinals#3156) * Document `ord env` (ordinals#3180) * Install openssl in docker image (ordinals#3181) * Release 0.16.0-rc0 (ordinals#3182) * Refactor test server to use arguments (ordinals#3183) * Update ordinals crate (ordinals#3184) * Release 0.16.0-rc1 (ordinals#3185) * Allow configuring interval between commits to index (ordinals#3186) * Credit contributors in changelog (ordinals#3187) * Make deploys noninteractive (ordinals#3189) * Make nop and burn tags one byte (ordinals#3207) * Encode claims as tag (ordinals#3206) * Add content proxy (ordinals#3216) * Add reinscribe option to batch file (ordinals#3220) * Check for duplicate satpoints in `satpoints` mode (ordinals#3221) * Overhaul settings (ordinals#3188) * Rename index_envelopes to index_inscriptions (ordinals#3233) * Test that runes can be minted with no edict (ordinals#3231) * Add libssl-dev to ubuntu install command (ordinals#3235) * Enable indexing runes on mainnet (ordinals#3236) * Document `ord wallet restore` (ordinals#3237) * Load config from default data dir and configure `ord env ` using config (ordinals#3240) * Document `ord env` commands (ordinals#3241) * Fix list numbering in handbook (ordinals#3248) * Display initial sync time on status page (ordinals#3250) * Create tempdir in download-log recipe (ordinals#3242) * Don't consider unconfirmed UTXOs as spent (ordinals#3255) * Reserve inscription tag 15 (ordinals#3256) * Rename genesis fee to inscription fee (ordinals#3257) * Add more fields to /r/blockinfo (ordinals#3260) * Add `id` inscription recursive JSON (ordinals#3258) * Document recursive endpoint backwards compatibility guarantees (ordinals#3265) * Release 0.16.0 (ordinals#3264) - Bump version: 0.16.0-rc1 → 0.16.0 - Update changelog - Update changelog contributor credits - Update dependencies * Bump ordinals version: 0.0.3 → 0.0.4 (ordinals#3267) --------- Co-authored-by: Casey Rodarmor <casey@rodarmor.com> Co-authored-by: oxSaturn <oxSaturn@proton.me> Co-authored-by: raph <raphjaph@protonmail.com> Co-authored-by: Robert Clarke <robert@rjfc.net> Co-authored-by: Davirain <davirain.yin@gmail.com> Co-authored-by: Jeremy Rubin <jeremy.l.rubin@gmail.com> Co-authored-by: mj10021 <jamesthespeedy@gmail.com> Co-authored-by: zhiqiangxu <652732310@qq.com> Co-authored-by: 0xLugon <lugon@alphatrue.com> Co-authored-by: Jerry the Martian <38183696+jerryfane@users.noreply.github.com> Co-authored-by: HarveyV <34950940+HarveyV@users.noreply.github.com> Co-authored-by: Michael Yu <michael@magiceden.io> Co-authored-by: lifofifo <134870335+devords@users.noreply.github.com> Co-authored-by: Eloc <42568538+elocremarc@users.noreply.github.com> Co-authored-by: Sitt Guruvanich <aekazitt@gmail.com> Co-authored-by: bingryan <41174435+bingryan@users.noreply.github.com> Co-authored-by: Andrew <47720952+andrewhong5297@users.noreply.github.com> Co-authored-by: Arik <arik-so@users.noreply.github.com>

Add router Runes balance and format Tx response to JSON

7c01621

Update path router Runes balances

38a179f

ordinals deleted a comment from alexluffy Jan 7, 2024

ordinals deleted a comment from doshidev99 Jan 7, 2024

raphjaph requested changes Jan 9, 2024

View reviewed changes

src/subcommand/server.rs Outdated Show resolved Hide resolved

lugondev and others added 4 commits January 28, 2024 12:27

Merge branch 'master' into master

5e2a906

Fix conflict: TransactionJson

83e6cc6

Add tests for endpoint /runes/balances

84bb95a

Format lint

3c8600d

raphjaph requested changes Jan 29, 2024

View reviewed changes

src/subcommand/server.rs Outdated Show resolved Hide resolved

src/subcommand/server.rs Outdated Show resolved Hide resolved

lugondev and others added 2 commits January 29, 2024 11:42

Update src/subcommand/server.rs

43e4f07

Co-authored-by: raph <raphjaph@protonmail.com>

Format lint

3598200

Add html page for /runes/balances

425748a

raphjaph added 11 commits January 30, 2024 15:10

only call function once

684927a

Amend

d3d3e66

fixit

e3ad081

Amend

5075b73

Amend

6a6f54f

Amend

a8d9d1d

Amend

8a73cd7

Make HTML nested tables

c4b6503

Amend

c98649b

Amend

0f0d3e5

Fix table formatting

e89a2f0

raphjaph approved these changes Jan 31, 2024

View reviewed changes

raphjaph added 4 commits January 30, 2024 21:14

remove CSS

9e21d5b

Make tests pretty

1e78daa

Revert CSS to master

e219c97

Revert CSS to master

3ba7f85

casey approved these changes Jan 31, 2024

View reviewed changes

raphjaph enabled auto-merge (squash) January 31, 2024 05:34

raphjaph merged commit d829fd2 into ordinals:master Jan 31, 2024
6 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add router Runes balance and format Tx response to JSON #2978

Add router Runes balance and format Tx response to JSON #2978

lugondev commented Jan 7, 2024

lugondev commented Jan 7, 2024

raphjaph left a comment

lugondev commented Jan 9, 2024

lugondev commented Jan 28, 2024 •

edited

Loading

raphjaph left a comment

lugondev commented Jan 29, 2024

lugondev commented Jan 29, 2024

lugondev commented Jan 30, 2024

raphjaph left a comment

lugondev commented Jan 31, 2024

casey left a comment

Add router Runes balance and format Tx response to JSON #2978

Add router Runes balance and format Tx response to JSON #2978

Conversation

lugondev commented Jan 7, 2024

lugondev commented Jan 7, 2024

raphjaph left a comment

Choose a reason for hiding this comment

lugondev commented Jan 9, 2024

lugondev commented Jan 28, 2024 • edited Loading

raphjaph left a comment

Choose a reason for hiding this comment

lugondev commented Jan 29, 2024

lugondev commented Jan 29, 2024

lugondev commented Jan 30, 2024

raphjaph left a comment

Choose a reason for hiding this comment

lugondev commented Jan 31, 2024

casey left a comment

Choose a reason for hiding this comment

lugondev commented Jan 28, 2024 •

edited

Loading