add prompt for seed when restoring wallet #3023

mj10021 · 2024-01-16T02:17:47Z

Fixes issue #2990 by allowing a seed to be entered to stdin when restoring a wallet. I'm not sure if I got the type coercion/checking exactly right here, so would appreciate any feedback/help. Thanks!

raphjaph

This is good start! Definitely add a an integration test somewhere in tests/wallet. If you need help with that let me know.

raphjaph · 2024-01-23T21:50:40Z

src/subcommand/wallet/restore.rs

@@ -1,9 +1,10 @@
 use super::*;
+use std::io;


combine these two

use { super::*, std::io, };

raphjaph · 2024-01-23T21:52:57Z

src/subcommand/wallet/restore.rs

+        println!("Please input your seed below:");
+        io::stdin().read_line(&mut input).expect("failed to read mnemonic");
+        let input = input.into_bytes();
+        assert_eq!(input.len(), 64);


not sure if we need this the Mnemonic might already perform these checks.

raphjaph · 2024-01-26T02:50:16Z

@mj10021 Have a look at #3048. I read the descriptor from stdin and also have some tests in there that you can use as a template.

mj10021 · 2024-01-26T12:52:53Z

thanks :) i'm away this weekend but should have done early next week

mj10021 · 2024-02-01T21:48:04Z

hey @raphjaph , just to clarify, is the stdin meant to accept a descriptor or a mnemonic?

mj10021 · 2024-02-02T14:54:41Z

hey @raphjaph , just to clarify, is the stdin meant to accept a descriptor or a mnemonic?

Oh I see, the --descriptor flag lets you enter a descriptor through stdin without the mnemonic

mj10021 · 2024-02-02T17:34:29Z

Ok, sorry, I actually do need some clarification. I see that now there is an option to restore from stdin and tests have already been made for that. Is this PR now redundant? Or is the option to load a mnemonic from stdin in addition to the descriptor flag also wanted? Thanks!

raphjaph · 2024-02-02T21:06:52Z

Ok, sorry, I actually do need some clarification. I see that now there is an option to restore from stdin and tests have already been made for that. Is this PR now redundant? Or is the option to load a mnemonic from stdin in addition to the descriptor flag also wanted? Thanks!

Yes we want to load the mnemonic from stdin only as well. And def also add a separate test for that. Let me know when this is ready for review.

mj10021 · 2024-02-03T14:11:10Z

Ok, sorry, I actually do need some clarification. I see that now there is an option to restore from stdin and tests have already been made for that. Is this PR now redundant? Or is the option to load a mnemonic from stdin in addition to the descriptor flag also wanted? Thanks!

Yes we want to load the mnemonic from stdin only as well. And def also add a separate test for that. Let me know when this is ready for review.

Ok got it thanks. I'm not able to run the tests atm but I think this should be right?

raphjaph · 2024-02-12T04:11:37Z

Tests aren't passing yet. Install just and run just ci to run all our tests.

mj10021 · 2024-02-15T00:37:15Z

Tests aren't passing yet. Install just and run just ci to run all our tests.

Got it, thanks. Should be good now.

raphjaph

LGTM

* Add recipe to deploy to all servers in fleet (ordinals#2992) * Suppress empty command output (ordinals#2995) * Optimize get_inscription_ids_by_sat_paginated (ordinals#2996) * Add crate to audit content security policy (ordinals#2993) * Remove dead link from README (ordinals#3000) * Add `indexed` to output JSON (ordinals#2971) * Cache less aggressively (ordinals#3002) * Add minimal Dockerfile (ordinals#2786) * Don't use browser sniffing when serving favicon (ordinals#3003) * Add option to retain sat index for spent outputs (ordinals#2999) * Hide BVM Network inscriptions (ordinals#3012) * Use --name instead of --wallet in README (ordinals#3010) * Add blocks and transaction JSON endpoints (ordinals#3004) * Inscribe with delegate (ordinals#3021) * Use untyped table API to get table info (ordinals#2747) * Make wallet communicate with index via RPC (ordinals#2929) * Break deploy recipes into multiple lines (ordinals#3026) * Test fee-spent inscription numbering (ordinals#3032) * Remove uneccessary allocations in Inscription Script Creation (ordinals#3039) * Better wallet error messages (ordinals#3041) * Add documentation for reinscriptions (ordinals#2963) * Exclude unnecessary docs (ordinals#3043) * Enable JSON API by default (ordinals#3047) * Forbid destinations in same-sat mode (ordinals#3038) * Dump and restore wallet from descriptors (ordinals#3048) * Add /runes/balances (ordinals#2978) * Make invariant message more concise (ordinals#3029) * Add dry run to send, print Outgoing and PSBT (ordinals#3063) * Use a flag to indicate a mint (ordinals#3068) * Move SatPoint into library (ordinals#3077) * [ordinals] Bump version: 0.0.1 → 0.0.2 (ordinals#3078) * Use min instead of clamp (ordinals#3081) * Make clippy stop complaining about insane repair callback (ordinals#3104) * Remove index parameter from index_block (ordinals#3088) * Allow specifying satpoint in `same-sat` batch inscribe (ordinals#3100) * Show reinscriptions in `ord wallet inscriptions` (ordinals#3101) * Move sat and friends into ordinals crate (ordinals#3079) * fix naming (ordinals#3112) * Return signed PSBT from `ord wallet send` (ordinals#3093) * Add /r/blockinfo endpoint (ordinals#3075) * Import multiple descriptors at a time (ordinals#3091) * Add `satpoints` batch inscribe mode (ordinals#3115) * Allow inscribing AVIF images (ordinals#3123) * Fix spelling mistake in bip.mediawiki (ordinals#3118) * Only allow mnemonic from stdin (ordinals#3023) * Emit inscription update events to channel (ordinals#3137) * Make Options public (ordinals#3138) * Use `image-rendering: auto` when downscaling images (ordinals#3144) * Add `ord env` to spin up a test bitcoin daemon and ord server (ordinals#3146) * Display inscription content type counts on /status (ordinals#3127) * Add optional HTTP authentication for server (ordinals#3131) * Make wallet async (ordinals#3142) * Add `/r/inscription` endpoint for getting inscription details (ordinals#2628) * Use `image-rendering: auto` for AVIF inscriptions (ordinals#3148) * Make `ord env` more user friendly (ordinals#3153) * Move JSON structs into api module (ordinals#3167) * Display parent above metadata on /inscription (ordinals#3160) * Represent rune IDs as `BLOCK:TX` (ordinals#3165) * Add parent preview to inscription page (ordinals#3163) * Update inscription sat documentation (ordinals#3114) * Fix lints (ordinals#3124) * Remove unnecessary lifetime from Formatter (ordinals#3178) * Print PSBT for dry run inscribe (ordinals#3116) * Update docs to reflect wallet changes (ordinals#3179) * Improve configuration (ordinals#3156) * Document `ord env` (ordinals#3180) * Install openssl in docker image (ordinals#3181) * Release 0.16.0-rc0 (ordinals#3182) * Refactor test server to use arguments (ordinals#3183) * Update ordinals crate (ordinals#3184) * Release 0.16.0-rc1 (ordinals#3185) * Allow configuring interval between commits to index (ordinals#3186) * Credit contributors in changelog (ordinals#3187) * Make deploys noninteractive (ordinals#3189) * Make nop and burn tags one byte (ordinals#3207) * Encode claims as tag (ordinals#3206) * Add content proxy (ordinals#3216) * Add reinscribe option to batch file (ordinals#3220) * Check for duplicate satpoints in `satpoints` mode (ordinals#3221) * Overhaul settings (ordinals#3188) * Rename index_envelopes to index_inscriptions (ordinals#3233) * Test that runes can be minted with no edict (ordinals#3231) * Add libssl-dev to ubuntu install command (ordinals#3235) * Enable indexing runes on mainnet (ordinals#3236) * Document `ord wallet restore` (ordinals#3237) * Load config from default data dir and configure `ord env ` using config (ordinals#3240) * Document `ord env` commands (ordinals#3241) * Fix list numbering in handbook (ordinals#3248) * Display initial sync time on status page (ordinals#3250) * Create tempdir in download-log recipe (ordinals#3242) * Don't consider unconfirmed UTXOs as spent (ordinals#3255) * Reserve inscription tag 15 (ordinals#3256) * Rename genesis fee to inscription fee (ordinals#3257) * Add more fields to /r/blockinfo (ordinals#3260) * Add `id` inscription recursive JSON (ordinals#3258) * Document recursive endpoint backwards compatibility guarantees (ordinals#3265) * Release 0.16.0 (ordinals#3264) - Bump version: 0.16.0-rc1 → 0.16.0 - Update changelog - Update changelog contributor credits - Update dependencies * Bump ordinals version: 0.0.3 → 0.0.4 (ordinals#3267) --------- Co-authored-by: Casey Rodarmor <casey@rodarmor.com> Co-authored-by: oxSaturn <oxSaturn@proton.me> Co-authored-by: raph <raphjaph@protonmail.com> Co-authored-by: Robert Clarke <robert@rjfc.net> Co-authored-by: Davirain <davirain.yin@gmail.com> Co-authored-by: Jeremy Rubin <jeremy.l.rubin@gmail.com> Co-authored-by: mj10021 <jamesthespeedy@gmail.com> Co-authored-by: zhiqiangxu <652732310@qq.com> Co-authored-by: 0xLugon <lugon@alphatrue.com> Co-authored-by: Jerry the Martian <38183696+jerryfane@users.noreply.github.com> Co-authored-by: HarveyV <34950940+HarveyV@users.noreply.github.com> Co-authored-by: Michael Yu <michael@magiceden.io> Co-authored-by: lifofifo <134870335+devords@users.noreply.github.com> Co-authored-by: Eloc <42568538+elocremarc@users.noreply.github.com> Co-authored-by: Sitt Guruvanich <aekazitt@gmail.com> Co-authored-by: bingryan <41174435+bingryan@users.noreply.github.com> Co-authored-by: Andrew <47720952+andrewhong5297@users.noreply.github.com> Co-authored-by: Arik <arik-so@users.noreply.github.com>

raphjaph requested changes Jan 23, 2024

View reviewed changes

mj10021 force-pushed the issue-2990-fix branch from 318e0fa to a6f3ea8 Compare February 2, 2024 19:29

mj10021 force-pushed the issue-2990-fix branch from a6f3ea8 to 65bd110 Compare February 3, 2024 14:09

mj10021 force-pushed the issue-2990-fix branch 6 times, most recently from 40989ae to 8a9db7c Compare February 3, 2024 17:45

casey linked an issue Feb 12, 2024 that may be closed by this pull request

Feature request: ord wallet restore to accept user input for MNEMONIC #2990

Closed

mj10021 force-pushed the issue-2990-fix branch from c0f6896 to f0dfbf8 Compare February 15, 2024 00:36

mj10021 added 2 commits February 14, 2024 22:26

add prompt for seed

2c978c4

update except message and start integration tests

4334037

mj10021 force-pushed the issue-2990-fix branch 3 times, most recently from 86f75ef to 8055d2f Compare February 15, 2024 03:34

fmt

2db9ecc

mj10021 force-pushed the issue-2990-fix branch from 8055d2f to 2db9ecc Compare February 15, 2024 03:56

raphjaph added 3 commits February 15, 2024 06:15

Merge branch 'master' into issue-2990-fix

3ceaffc

Simplify and tests

58912f1

Amend

adf021e

raphjaph added 3 commits February 15, 2024 17:14

Merge branch 'master' of github.com:ordinals/ord into issue-2990-fix

024ecf7

Amend

1d0f83c

Amend

a30b498

raphjaph enabled auto-merge (squash) February 16, 2024 18:18

raphjaph approved these changes Feb 16, 2024

View reviewed changes

raphjaph merged commit aff1044 into ordinals:master Feb 16, 2024
6 checks passed

BrewTestBot mentioned this pull request Mar 11, 2024

ord 0.16.0 Homebrew/homebrew-core#165814

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add prompt for seed when restoring wallet #3023

add prompt for seed when restoring wallet #3023

mj10021 commented Jan 16, 2024

raphjaph left a comment

raphjaph Jan 23, 2024

raphjaph Jan 23, 2024

raphjaph commented Jan 26, 2024

mj10021 commented Jan 26, 2024

mj10021 commented Feb 1, 2024

mj10021 commented Feb 2, 2024

mj10021 commented Feb 2, 2024

raphjaph commented Feb 2, 2024 •

edited

Loading

mj10021 commented Feb 3, 2024

raphjaph commented Feb 12, 2024

mj10021 commented Feb 15, 2024

raphjaph left a comment

add prompt for seed when restoring wallet #3023

add prompt for seed when restoring wallet #3023

Conversation

mj10021 commented Jan 16, 2024

raphjaph left a comment

Choose a reason for hiding this comment

raphjaph Jan 23, 2024

Choose a reason for hiding this comment

raphjaph Jan 23, 2024

Choose a reason for hiding this comment

raphjaph commented Jan 26, 2024

mj10021 commented Jan 26, 2024

mj10021 commented Feb 1, 2024

mj10021 commented Feb 2, 2024

mj10021 commented Feb 2, 2024

raphjaph commented Feb 2, 2024 • edited Loading

mj10021 commented Feb 3, 2024

raphjaph commented Feb 12, 2024

mj10021 commented Feb 15, 2024

raphjaph left a comment

Choose a reason for hiding this comment

raphjaph commented Feb 2, 2024 •

edited

Loading