Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recursive Runes Endpoint Output #3654

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

elocremarc
Copy link
Contributor

@elocremarc elocremarc commented Apr 22, 2024

/r/output/:output

Its time for the output endpoint

image

Example of runes with an inscription https://ordinals.com/output/b84a1dd3cfb9ebb26f240afe7f17bf73f8a1b6cc9774ea26e360fbe077a26669:0

I just proxied the current /output response to play around with it. What do we want to keep or remove from the fields? We want at least runes inscriptions. This allows artist to choose if they want to activate an inscription via a rune or via an inscription on the output.

Another cool thing to have would be sat ranges. Then you can start activating inscriptions based on sats in the output if you don't want to activate an inscription with runes or inscriptions. Output gives you all 3 options activating inscriptions with sats, inscriptions or runes.

@PirateCodeWeb3
Copy link

this is amazing, LFG

@lifofifoX
Copy link
Collaborator

One of the reasons I had used /r/inscription/:inscription_id/rune/:rune_id in #3538 over output was so that the recursive endpoints would not be ephemeral. Output endpoints would probably also need to be paginated, scoping by rune_id avoids that.

@elocremarc
Copy link
Contributor Author

@devords
Yeah we probably need to paginate this in some way. I do like being able to target one rune. However why force the user to know the rune id? This way you don't even need to know about the runes held. This means that an inscription could still be compatible to future runes. Also this would give us access to more than just runes like the inscriptions on the output as well as the sat ranges. I think the sat ranges are far super interesting and already have fun uses for it.

Could there be a way to combine both ours for different use cases? The sat endpoint has the /at as well as the paginated one. Output is something I have wanted before we even started on these endpoints.
heres me talking about output in your last recursive PR
#2628 (comment)

@alexamizz
Copy link

I was able to produce the output with both an inscription and rune. However, it looks like the inscription and rune is now soulbound. It will not let me separate. I was thinking this could be a cool solution for upcoming projects to include runes with the inscriptions when someone goes to "mint". Kinda like a package deal.

https://signet.ordstuff.info/output/e00ef72ec8aea33553cce8b41bfc0c7cbf7044563c24b02d11b21eadfc6da538:0
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Ready for Review
Development

Successfully merging this pull request may close these issues.

4 participants