Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boost lambda ist not working for boost 1.57 and clang 3.4, 3.5, 3.6, … #103

Merged
merged 2 commits into from
Jun 12, 2015

Conversation

goldhoorn
Copy link
Member

This PR superseeds #98 because of longer vacation

@snrkiwi
Copy link
Contributor

snrkiwi commented Jun 12, 2015

Looks good to me.

smits pushed a commit that referenced this pull request Jun 12, 2015
boost lambda ist not working for boost 1.57 and clang 3.4, 3.5, 3.6, …
@smits smits merged commit ff33781 into master Jun 12, 2015
@smits
Copy link
Member

smits commented Jun 12, 2015

lgtm

@meyerj
Copy link
Member

meyerj commented Jan 10, 2017

Is it correct that the only motivation for this patch was to avoid boost::lambda? That's what I read from the commit message. Or are there any other advantages of std::bind vs. boost::bind?

I think the patch is somehow incomplete as not all occurrences of boost::bind have been replaced and we have a mix of Boost and C++11 functions now (e.g. OperationInterfacePartFused.hpp:220 and many others that have not been touched at all). I proposed an alternative solution using boost::arg<i> instead of boost::lambda::_i in #196, which might also solve the problem that motivated this patch. I will try to revert this patch, replace lambdas by boost::arg<i> instead and check if RTT compiles with Boost 1.58 and clang. I guess the standard Ubuntu Xenial set of packages (Boost 1.58 and Clang 3.8) would reveal the original problem.

@meyerj
Copy link
Member

meyerj commented Jan 10, 2017

Please check the alternative solution in #201. I noticed that Boost Lambda was used for some expressions other than only placeholders, but those could be simply replaced by standard C++ and Boost Bind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants