Revert USE_CPP11 patch and eliminate boost lambda outside scripting #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oost Bind usage Signed-off-by: Johannes Meyer <johannes@intermodalics.eu>
This was referenced Jan 10, 2017
|
@smits Could you please verify that this patch compiles and works in Mac OS X before we merge it? |
meyerj
added a commit
that referenced
this pull request
Oct 26, 2017
The USE_CPP11 cmake option and preprocessor macro was removed in #201 and is not defined anymore. The merge with the toolchain-2.9 branch in f024872 resolved some conflicts, but did not remove the USE_CPP11 check that has been added in rtt/base/ChannelElement.hpp as part of #114. Signed-off-by: Johannes Meyer <johannes@intermodalics.eu>
meyerj
added a commit
that referenced
this pull request
Oct 26, 2017
The USE_CPP11 cmake option and preprocessor macro was removed in #201 and is not defined anymore. The merge with the toolchain-2.9 branch in f024872 resolved some conflicts, but did not remove the USE_CPP11 check that has been added in rtt/base/ChannelElement.hpp as part of #114. Signed-off-by: Johannes Meyer <johannes@intermodalics.eu>
meyerj
added a commit
that referenced
this pull request
Oct 26, 2017
The USE_CPP11 cmake option and preprocessor macro was removed in #201 and is not defined anymore. The merge with the toolchain-2.9 branch in f024872 resolved some conflicts, but did not remove the USE_CPP11 check that has been added in rtt/base/ChannelElement.hpp as part of #114. Signed-off-by: Johannes Meyer <johannes@intermodalics.eu>
francisco-miguel-almeida
pushed a commit
that referenced
this pull request
Apr 5, 2019
The USE_CPP11 cmake option and preprocessor macro was removed in #201 and is not defined anymore. The merge with the toolchain-2.9 branch in f024872 resolved some conflicts, but did not remove the USE_CPP11 check that has been added in rtt/base/ChannelElement.hpp as part of #114. Signed-off-by: Johannes Meyer <johannes@intermodalics.eu>
francisco-miguel-almeida
pushed a commit
that referenced
this pull request
Apr 9, 2019
The USE_CPP11 cmake option and preprocessor macro was removed in #201 and is not defined anymore. The merge with the toolchain-2.9 branch in f024872 resolved some conflicts, but did not remove the USE_CPP11 check that has been added in rtt/base/ChannelElement.hpp as part of #114. Signed-off-by: Johannes Meyer <johannes@intermodalics.eu>
meyerj
added a commit
that referenced
this pull request
May 16, 2019
The USE_CPP11 cmake option and preprocessor macro was removed in #201 and is not defined anymore. The merge with the toolchain-2.9 branch in f024872 resolved some conflicts, but did not remove the USE_CPP11 check that has been added in rtt/base/ChannelElement.hpp as part of #114. Signed-off-by: Johannes Meyer <johannes@intermodalics.eu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverts the introduction of the
USE_CPP11cmake option and preprocessor guard introduced in #103, which I would consider as hotfix. Instead, it eliminates all usages of Boost Lambda outside RTT scripting and unifies the placeholder syntax forboost::bind():_1<-- preferedboost::lambda::_1::_1Tested with the following combinations of platforms, compilers and Boost: