Add accessors #419
Merged
Add accessors #419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add accessors of scale and offset
add accessor of f_tip
add accessor of h
change return types of getMass() and getRotationalInertia()
privat variale this->tree to a const reference
|
I will have to check which changes are ABI compatible. As these are small changes, 8 don't want to break ABI compatibility for it. |
|
@MatthijsBurgh |
const double& getMass() -> double getMass()
|
@MatthijsBurgh |
Not ABI compatible
Not ABI compatible
Not ABI compatible
|
@Masa0u0 These are the only ABI compatible changes. |
|
@MatthijsBurgh |
|
@Masa0u0 could you add missing docstring to the added function in |
getFrameToTipRaw -> getFrameToTipZero add docstring to get FrameToTipZero
add docstring to get FrameToTipZero
|
@MatthijsBurgh |
MatthijsBurgh
approved these changes
Nov 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello. I am a university student in Japan.
I propose the following two things
orocos_kdl will be easier to use. Please consider.