osbuild: only mount the required mountpoints for bootc install (COMPOSER-2301) #846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bootc install to-filesystem requires a clean root to install, with only the required mountpoints present: /, /boot, and /boot/efi. Do not mount any user-defined mountpoints when running the bootc install stage. Content in bootc images cannot be separated across filesystems, therefore there cannot be any content under the custom mountpoints, so this change will not cause any issues of content not being on the correct filesystem.
thozza
approved these changes
Aug 9, 2024
achilleas-k
added a commit
to achilleas-k/bootc-image-builder
that referenced
this pull request
Aug 9, 2024
achilleas-k
added a commit
to achilleas-k/bootc-image-builder
that referenced
this pull request
Aug 9, 2024
mvo5
added a commit
to mvo5/images
that referenced
this pull request
Aug 12, 2024
…Stage Small tweak for the tests for `NewBootcInstallToFilesystemStage` so that we also test that only the essential mounts are used in the `org.osbuild.bootc.install-to-filesystem`. This also makes the fake creation for /boot/efi more realistic by moving the fs to `vfat`. Tiny followup for osbuild#846
mvo5
added a commit
to mvo5/images
that referenced
this pull request
Aug 12, 2024
…Stage Small tweak for the tests for `NewBootcInstallToFilesystemStage` so that we also test that only the essential mounts are used in the `org.osbuild.bootc.install-to-filesystem`. This also makes the fake creation for /boot/efi more realistic by moving the fs to `vfat`. Tiny followup for osbuild#846
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 12, 2024
…Stage Small tweak for the tests for `NewBootcInstallToFilesystemStage` so that we also test that only the essential mounts are used in the `org.osbuild.bootc.install-to-filesystem`. This also makes the fake creation for /boot/efi more realistic by moving the fs to `vfat`. Tiny followup for #846
achilleas-k
added a commit
to achilleas-k/bootc-image-builder
that referenced
this pull request
Aug 14, 2024
github-merge-queue bot
pushed a commit
to osbuild/bootc-image-builder
that referenced
this pull request
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bootc install to-filesystem requires a clean root to install, with only the required mountpoints present: /, /boot, and /boot/efi. Do not mount any user-defined mountpoints when running the bootc install stage.
Content in bootc images cannot be separated across filesystems, therefore there cannot be any content under the custom mountpoints, so this change will not cause any issues of content not being on the correct filesystem.
See also the discussion at osbuild/bootc-image-builder#579