Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go.mod: replace golang.org/x/exp/slices with slices #849

Merged
merged 1 commit into from
Aug 10, 2024

Conversation

achilleas-k
Copy link
Member

@achilleas-k achilleas-k commented Aug 9, 2024

go.mod: replace golang.org/x/exp/slices with slices

Since we updated the go version to 1.21, we can use the stdlib slices package, instead of the x/exp version of it.

Branch is based on #846.

ondrejbudai
ondrejbudai previously approved these changes Aug 9, 2024
Copy link
Member

@ondrejbudai ondrejbudai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay!

@achilleas-k achilleas-k added this pull request to the merge queue Aug 9, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to invalid changes in the merge commit Aug 9, 2024
@achilleas-k
Copy link
Member Author

ugh, automatic rebase doesn't like the first commit. Fixing.

Since we updated the go version to 1.21, we can use the stdlib slices
package, instead of the x/exp version of it.
Copy link
Contributor

@bcl bcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh darn, now I will have to remember not to point out that we can't use it yet ;)

@achilleas-k achilleas-k added this pull request to the merge queue Aug 10, 2024
Merged via the queue into osbuild:main with commit fee2848 Aug 10, 2024
16 of 18 checks passed
@achilleas-k achilleas-k deleted the slices branch August 12, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants