Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Lie algebras] misc bugfixes, root system in Lie alg interface,
dim_of_simple_module
implementation in julia #4030[Lie algebras] misc bugfixes, root system in Lie alg interface,
dim_of_simple_module
implementation in julia #4030Changes from 12 commits
9b3aca6
56d036b
884d429
80ca42c
210ddaf
df65a6a
683e9b3
764a62a
746ac41
50c7982
9774f8f
2d1c537
7ea927d
b08d84f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems this function was only moved, why was the doc string deleted?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The docstring is now attached to
chevalley_basis(::LieAlgebra)
, as it contained nothing specific for the Lie algebra subtypeThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another off-topic comment, but: perhaps we should agree to whom docstrings of exported (documented) functions are addressed. I'd say it should be users. Of course sometimes there is also a point in adding some remarks for implementors. But I think those then should be marked explicitly as such, e.g. via a callout (so the
!!!
syntax). That said, in this case I think one could just rephrase it slightly:or so?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the remark. I collected the information about which functions need to be implemented by subtypes that support root systems to the general list about subtype-implemented functions to the top. Furthermore, the docstrings are adapted to reflect what users need to know. (Note that I don't have to mention subtypes with no root system support there, as in these cases
has_root_system
should always returnfalse
, i.e. theNotImplemented()
should never trigger.). Changes in 7ea927dCheck warning on line 464 in experimental/LieAlgebras/src/LieAlgebra.jl
Codecov / codecov/patch
experimental/LieAlgebras/src/LieAlgebra.jl#L462-L464
Check warning on line 476 in experimental/LieAlgebras/src/LieAlgebra.jl
Codecov / codecov/patch
experimental/LieAlgebras/src/LieAlgebra.jl#L474-L476
Check warning on line 970 in experimental/LieAlgebras/src/RootSystem.jl
Codecov / codecov/patch
experimental/LieAlgebras/src/RootSystem.jl#L969-L970