-
Notifications
You must be signed in to change notification settings - Fork 497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📖 Clarify CII-Best-Practices score for each badge #2313
Conversation
Integration tests success for |
d85f591
to
afd5cad
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2313 +/- ##
=======================================
Coverage 40.61% 40.61%
=======================================
Files 112 112
Lines 8831 8831
=======================================
Hits 3587 3587
Misses 4984 4984
Partials 260 260 |
Integration tests success for |
Integration tests success for |
Thanks for catching this. The contents of |
Done! Spotted a typo at the same time :) |
Integration tests success for |
Integration tests success for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for catching and fixing this!
46b21e3
to
c51d018
Compare
Integration tests success for |
Signed-off-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
Signed-off-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
Signed-off-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
c51d018
to
c6dbcab
Compare
Integration tests success for |
* Clarify CII-Best-Practices score for each badge Signed-off-by: Hugo van Kemenade <hugovk@users.noreply.github.com> * Clarify CII-Best-Practices score for each badge Signed-off-by: Hugo van Kemenade <hugovk@users.noreply.github.com> * Move to checks.yaml and regenerate Signed-off-by: Hugo van Kemenade <hugovk@users.noreply.github.com> Signed-off-by: Hugo van Kemenade <hugovk@users.noreply.github.com> Signed-off-by: latortuga <latortugaaaa>
* Clarify CII-Best-Practices score for each badge Signed-off-by: Hugo van Kemenade <hugovk@users.noreply.github.com> * Clarify CII-Best-Practices score for each badge Signed-off-by: Hugo van Kemenade <hugovk@users.noreply.github.com> * Move to checks.yaml and regenerate Signed-off-by: Hugo van Kemenade <hugovk@users.noreply.github.com> Signed-off-by: Hugo van Kemenade <hugovk@users.noreply.github.com> Signed-off-by: nathaniel.wert <nathaniel.wert@kudelskisecurity.com>
* Clarify CII-Best-Practices score for each badge Signed-off-by: Hugo van Kemenade <hugovk@users.noreply.github.com> * Clarify CII-Best-Practices score for each badge Signed-off-by: Hugo van Kemenade <hugovk@users.noreply.github.com> * Move to checks.yaml and regenerate Signed-off-by: Hugo van Kemenade <hugovk@users.noreply.github.com> Signed-off-by: Hugo van Kemenade <hugovk@users.noreply.github.com> Signed-off-by: nathaniel.wert <nathaniel.wert@kudelskisecurity.com>
* Clarify CII-Best-Practices score for each badge Signed-off-by: Hugo van Kemenade <hugovk@users.noreply.github.com> * Clarify CII-Best-Practices score for each badge Signed-off-by: Hugo van Kemenade <hugovk@users.noreply.github.com> * Move to checks.yaml and regenerate Signed-off-by: Hugo van Kemenade <hugovk@users.noreply.github.com> Signed-off-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
What kind of change does this PR introduce?
(Is it a bug fix, feature, docs update, something else?)
Docs update.
What is the current behavior?
Currently it sounds like you get the full 10 for a passing badge.
But the code disagrees:
What is the new behavior (if this is a feature change)?**
Fix the docs to match the code.
Which issue(s) this PR fixes
Special notes for your reviewer
Does this PR introduce a user-facing change?
For user-facing changes, please add a concise, human-readable release note to
the
release-note
(In particular, describe what changes users might need to make in their
application as a result of this pull request.)