GB28181: Support external SIP server. v6.0.144 #4101
Conversation
|
https://ossrs.net/lts/zh-cn/docs/v5/doc/gb28181#usage |
Yeah, this is the work I am currently doing, and I will submit the changes as soon as possible. Update: ossrs/srs-docs#67 |
| @@ -421,12 +425,12 @@ srs_error_t SrsGbListener::initialize(SrsConfDirective* conf) | |||
|
|
|||
| bool sip_enabled = _srs_config->get_stream_caster_sip_enable(conf); | |||
| if (!sip_enabled) { | |||
| return srs_error_new(ERROR_GB_CONFIG, "GB SIP is required"); | |||
| srs_warn("GB SIP is disabled."); | |||
There was a problem hiding this comment.
one more thing to review. About the conf directives of sip.enable:
Lines 681 to 683 in ea7e2c2
The code here means: GB internal SIP is disabled, so don't break the GB process, SRS can still support the external SIP.
So, there are a few thing to consider:
- improve the log:
GB [internal|embedded] SIP is disabled; - Internal SIP is no longer a necessary one, so use
srs_traceto replacesrs_warn; - Maybe rename
sip_enabletointernal_sip_enabled; - External sip is the future, so no need to enable or disable it?
There was a problem hiding this comment.
In essence, the external SIP server is not part of SRS. You can look at my implementation, even use it directly, but it's not mandatory. So, I don't want to modify it for now.
winlinvip
changed the title
winlinvip
changed the title
For #3369 to support an external powerful SIP server, do not use the embedded SIP server of SRS.
For more information, detailed steps, system architecture, and background explanation, please see https://ossrs.net/lts/zh-cn/docs/v6/doc/gb28181#external-sip
Co-authored-by: Jacob Su suzp1984@gmail.com