Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GB28181: Support external SIP server. v6.0.144 #4101
GB28181: Support external SIP server. v6.0.144 #4101
Changes from 2 commits
47b9fdb
67d0a9f
a6f0cac
9a63972
3fa141f
a16c6ef
7393105
4ec9c2a
8634cf2
560259d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one more thing to review. About the conf directives of
sip.enable
:srs/trunk/conf/full.conf
Lines 681 to 683 in ea7e2c2
The code here means:
GB internal SIP is disabled
, so don't break the GB process, SRS can still support the external SIP.So, there are a few thing to consider:
GB [internal|embedded] SIP is disabled
;srs_trace
to replacesrs_warn
;sip_enable
tointernal_sip_enabled
;There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In essence, the external SIP server is not part of SRS. You can look at my implementation, even use it directly, but it's not mandatory. So, I don't want to modify it for now.