protocol sdk - make MintAPIClient a class, with overridable http methods. add full fledged mint examples. refactor MintClient #368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
oveddan
force-pushed
the
protocol-sdk-split-up-1155-and-721-mint
branch
3 times, most recently
from
1a04173 to
7cd70e4
Compare
|
running into this; doesn't play well with viem types 
|
This was referenced Nov 28, 2023
Closed
Closed
oveddan
force-pushed
the
protocol-sdk-split-up-1155-and-721-mint
branch
from
7cd70e4 to
c8619de
Compare
oveddan
changed the title
oveddan
force-pushed
the
protocol-sdk-split-up-1155-and-721-mint
branch
from
3717b77 to
36d98a7
Compare
oveddan
changed the title
iainnash
reviewed
Nov 28, 2023
| @@ -1,6 +1,8 @@ | |||
| import { retries, get, post } from "../apis/http-api-base"; | |||
| import * as httpClientBase from "../apis/http-api-base"; | |||
There was a problem hiding this comment.
nit: not really a fan of import * unless it’s import * as .
There was a problem hiding this comment.
agree that this is weird. an interface would make more sense
There was a problem hiding this comment.
just did a fix, by exporting an interface and leveraging that. let me know what you think
oveddan
force-pushed
the
protocol-sdk-split-up-1155-and-721-mint
branch
from
eda7969 to
f1f2b4d
Compare
iainnash
previously approved these changes
Nov 28, 2023
oveddan
force-pushed
the
protocol-sdk-split-up-1155-and-721-mint
branch
from
f1f2b4d to
684cc22
Compare
iainnash
pushed a commit
that referenced
this pull request
Jan 5, 2024
…ods. add full fledged mint examples. refactor MintClient (#368) * makePrepareMintTOkenParams returns single object publicClient is optional in test * updated changeset * better tsdoc comments. dont expose all methods * make token id optional * added interface for IHttpClient * fix prettier
iainnash
pushed a commit
that referenced
this pull request
Jan 11, 2024
…ods. add full fledged mint examples. refactor MintClient (#368) * makePrepareMintTOkenParams returns single object publicClient is optional in test * updated changeset * better tsdoc comments. dont expose all methods * make token id optional * added interface for IHttpClient * fix prettier
iainnash
pushed a commit
that referenced
this pull request
Jan 11, 2024
…ods. add full fledged mint examples. refactor MintClient (#368) * makePrepareMintTOkenParams returns single object publicClient is optional in test * updated changeset * better tsdoc comments. dont expose all methods * make token id optional * added interface for IHttpClient * fix prettier
oveddan
added a commit
that referenced
this pull request
May 10, 2024
<!--- Provide a general summary of your changes in the Title above --> ## Description <!--- Describe your changes in detail --> ## Motivation and Context <!--- Why is this change required? What problem does it solve? --> <!--- If it fixes an open issue, please link to the issue here. --> ## Does this change the ABI/API? - [ ] This changes the ABI/API <!-- If so, please describe how and what potential impact this may have --> ## What tests did you add/modify to account for these changes <!--- Please describe in detail how you tested your changes. --> <!--- Include details of your testing environment, tests ran to see how --> <!--- your change affects other areas of the code, etc. --> ## Types of changes <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New module / feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) ## Checklist: <!--- Go over all the following points, and put an `x` in all the boxes that apply. --> <!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> - [ ] My code follows the code style of this project. - [ ] My change requires a change to the documentation. - [ ] I have updated the documentation accordingly. - [ ] i added a changeset to account for this change ## Reviewer Checklist: - [ ] My review includes a symposis of the changes and potential issues - [ ] The code style is enforced - [ ] There are no risky / concerning changes / additions to the PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to
MintApliClientandMintClient, with descriptions described in the changeset