premint v2 sdk #387
Closed
premint v2 sdk #387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 22, 2023
Closed
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
Closed
oveddan
commented
Nov 22, 2023
| keccak256( | ||
| abi.encode(ATTRIBUTION_DOMAIN_V1, _hashToken(premintConfig.tokenConfig), premintConfig.uid, premintConfig.version, premintConfig.deleted) | ||
| ); | ||
| function hashPremint(TokenCreationConfig memory tokenConfig, PremintSettings memory settings) internal pure returns (bytes32) { |
There was a problem hiding this comment.
this file change doens't belong in this PR
oveddan
force-pushed
the
deploy-2.5.2-testnets
branch
from
2c95d26 to
be9a0ed
Compare
oveddan
force-pushed
the
premint-v2-auth-check-change
branch
from
6f54b28 to
cc652d1
Compare
oveddan
requested review from
kolber,
mattlenz,
ligustah,
jackiehluo and
zakkvry
Base automatically changed from
deploy-2.5.2-testnets
to
fix-premint-v2-encoding
November 27, 2023 17:22
oveddan
force-pushed
the
premint-v2-auth-check-change
branch
from
d36f3da to
0c43bbf
Compare
oveddan
force-pushed
the
premint-v2-auth-check-change
branch
from
0c43bbf to
71dfef9
Compare
iainnash
reviewed
Nov 28, 2023
.github/workflows/lint.yml
Outdated
| @@ -2,7 +2,7 @@ name: Lint | |||
| on: [pull_request] | |||
|
|
|||
| jobs: | |||
| inspect-storage: | |||
| lint: | |||
There was a problem hiding this comment.
should this be another PR?
oveddan
changed the base branch from
main
to
protocol-sdk-split-up-1155-and-721-mint
oveddan
force-pushed
the
premint-v2-auth-check-change
branch
from
71dfef9 to
3acfe3f
Compare
Base automatically changed from
protocol-sdk-split-up-1155-and-721-mint
to
main
November 28, 2023 20:49
oveddan
changed the base branch from
main
to
minimal-premint-client-refactor
oveddan
force-pushed
the
premint-v2-auth-check-change
branch
from
3acfe3f to
ed22deb
Compare
oveddan
force-pushed
the
premint-v2-auth-check-change
branch
from
ed22deb to
27d18e7
Compare
oveddan
force-pushed
the
premint-v2-auth-check-change
branch
2 times, most recently
from
4a70aaf to
0a5abb4
Compare
oveddan
force-pushed
the
premint-v2-auth-check-change
branch
from
0a5abb4 to
833f1ba
Compare
oveddan
force-pushed
the
premint-v2-auth-check-change
branch
from
038bc74 to
702ad19
Compare
oveddan
force-pushed
the
fix-lint-task
branch
from
ba73d27 to
c37cf99
Compare
oveddan
force-pushed
the
premint-v2-auth-check-change
branch
from
c9c9fc8 to
9025ddf
Compare
oveddan
force-pushed
the
premint-v2-auth-check-change
branch
from
ef246c2 to
f753072
Compare
iainnash
reviewed
Nov 30, 2023
| export type PremintConfigV2 = PremintV2HashDataTypes[1]; | ||
| export type TokenCreationConfigV2 = PremintConfigV2["tokenConfig"]; | ||
|
|
||
| const v1Types = { |
There was a problem hiding this comment.
nit: Should we put this into another file?
iainnash
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Premint sdk now supports premint v2. See the added changeset for a summary of changes.
ToDo: