Kubernetes jobs.yml template ignores RUN_FORUM #525
Comments
fghaas
added a commit
to fghaas/tutor
that referenced
this issue
Nov 17, 2021
When running "tutor k8s" we can disable the forum deployment and service by setting RUN_FORUM to false, but the corresponding job is added to jobs.yml unconditionally. Add a conditional to templates/k8s/jobs.yml so that the forum job definition is only included when RUN_FORUM is true. Fixes overhangio#525.
fghaas
added a commit
to fghaas/tutor
that referenced
this issue
Nov 17, 2021
When running "tutor k8s" we can disable the forum deployment and service by setting RUN_FORUM to false, but the corresponding job is added to jobs.yml unconditionally. Add a conditional to tutor/templates/k8s/jobs.yml so that the forum job definition is only included when RUN_FORUM is true. Fixes overhangio#525.
fghaas
added a commit
to fghaas/tutor
that referenced
this issue
Nov 17, 2021
When running "tutor k8s" we can disable the forum deployment and service by setting RUN_FORUM to false, but the corresponding job is added to jobs.yml unconditionally. Add a conditional to tutor/templates/k8s/jobs.yml so that the forum job definition is only included when RUN_FORUM is true. Fixes overhangio#525.
fghaas
added a commit
to fghaas/tutor
that referenced
this issue
Nov 18, 2021
When running "tutor k8s" we can disable the forum deployment and service by setting RUN_FORUM to false, but the corresponding job is added to jobs.yml unconditionally. Add a conditional to tutor/templates/k8s/jobs.yml so that the forum job definition is only included when RUN_FORUM is true. Fixes overhangio#525.
regisb
pushed a commit
that referenced
this issue
Nov 18, 2021
When running "tutor k8s" we can disable the forum deployment and service by setting RUN_FORUM to false, but the corresponding job is added to jobs.yml unconditionally. Add a conditional to tutor/templates/k8s/jobs.yml so that the forum job definition is only included when RUN_FORUM is true. Fixes #525.
regisb
added a commit
that referenced
this issue
Nov 18, 2021
- [Security] Timed exam security fix [29347](https://github.com/edx/edx-platform/pull/29347). - [Feature] Add [tutor-richie](https://github.com/overhangio/tutor-richie) to the plugins that are bundled with the tutor binary. - [Improvement] Make `tutor plugins list` print plugins sorted by name. - [Improvement] Ignore Python plugins which cannot be loaded. - [Bugfix] When configured with `RUN_FORUM: false`, omit forum-related [Jobs](https://kubernetes.io/docs/concepts/workloads/controllers/job/) from the manifests that `tutor k8s` generates. (#525)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Bug description
When running
tutor k8swe can disable the forum deployment and service by settingRUN_FORUMtofalse, but the corresponding job is added tojobs.ymlunconditionally.How to reproduce
RUN_FORUM: Falseintutor/config.ymltutor k8s quickstart$TUTOR_ROOT/env/k8s/deployments.ymlorservices.yml, but there is a job namedforum-jobinjobs.yml.Environment
(The fix for this should be trivial; PR incoming.)
The text was updated successfully, but these errors were encountered: