Include the forum job only if RUN_FORUM is set #526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fghaas
force-pushed
the
jobs-run-forum
branch
from
eef84ee
to
d939e3d
Compare
regisb
requested changes
Nov 18, 2021
There was a problem hiding this comment.
Good catch! This will be unnecessary soon, when the forum is pulled out of tutor core, but in the meantime we need this fix.
Can you just add an entry to the changelog?
When running "tutor k8s" we can disable the forum deployment and service by setting RUN_FORUM to false, but the corresponding job is added to jobs.yml unconditionally. Add a conditional to tutor/templates/k8s/jobs.yml so that the forum job definition is only included when RUN_FORUM is true. Fixes overhangio#525.
fghaas
force-pushed
the
jobs-run-forum
branch
from
d939e3d
to
cf10fc9
Compare
Sure, done. |
regisb
approved these changes
Nov 18, 2021
|
Thanks for the PR @fghaas! |
|
Thanks for merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running
tutor k8swe can disable the forum deployment and service by settingRUN_FORUMtofalse, but the corresponding job is added tojobs.ymlunconditionally.Add a conditional to
tutor/templates/k8s/jobs.ymlso that the forum job definition is only included whenRUN_FORUMistrue.Fixes #525.