Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option for OWNCLOUD_ALLOW_EXTERNAL_LOCAL_STORAGE #16

Merged
merged 3 commits into from
Mar 7, 2018

Conversation

vkhurana
Copy link

@vkhurana vkhurana commented Feb 3, 2018

This allows docker containers to override the specific config.php option to allow Local folders to be mounted in external storage.

The option was added in config.php (and disabled by default) with PR#27590 (owncloud/core#27590)

This PR adds a Environment Variable that allows containers to set that value in config.php

@vkhurana
Copy link
Author

vkhurana commented Feb 7, 2018

This would be useful for people that want to deploy OwnCloud using docker, and want to mount local storage. Currently, the owncloud instance needs to be edittied manually to allow Local Mounts.

@tboerger
Copy link
Contributor

tboerger commented Feb 8, 2018

This can already be done with an occ command, but beside that I would prefer to have an empty default value and call occ if the value is true or false.

@vkhurana
Copy link
Author

vkhurana commented Feb 8, 2018

@tboerger Thanks for the feedback!

I agree with your comments. I have updated it to take effect using the occ command.

I've made the changes in rootfs/etc/owncloud.d/90-services.sh but if you think it would be more suited in a different file, please let me know.

Copy link
Contributor

@tboerger tboerger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vkhurana
Copy link
Author

vkhurana commented Feb 9, 2018

@tboerger thanks!

@vkhurana vkhurana closed this Feb 9, 2018
@vkhurana vkhurana reopened this Feb 9, 2018
@patrickjahns
Copy link
Contributor

Right now it is missing the case, when OWNCLOUD_ALLOW_EXTERNAL_LOCAL_STORAGE was once defined, but in a successive container start removed

@vkhurana
Copy link
Author

vkhurana commented Feb 9, 2018

@patrickjahns that's a good point - should we default it to false, to prevent that case?

@tboerger
Copy link
Contributor

IMHO it's fine like it is... If somebody drops the option it's up to him to drop this flag. Otherwise we would also the behavior of existing installations

@patrickjahns
Copy link
Contributor

@tboerger
merge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants