Option to mount a new local storage disabled #27590

noveens · 2017-04-06T19:56:08Z

Description

Option to mount a new local storage removed unless files_external_allow_create_new_local variable specifically set to true in config.php

Related Issue

#26653

How Has This Been Tested?

Included the files_external_allow_create_new_local option and set to true and false, works as desired

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

My code follows the code style of this project.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes.
All new and existing tests passed.

@PVince81

noveens · 2017-04-06T19:58:38Z

To discuss :

The colored status indicator for already existing local mounts at the http://localhost/core/index.php/settings/admin?sectionid=storage page always turns to RED even if being displayed at the home page.
The log fills up like hell.

@PVince81 ?

PVince81 · 2017-04-07T07:16:08Z

Are these two checkbox items related to your change or do you observe these also on master ?
What log entries ?

noveens · 2017-04-07T12:12:19Z

@PVince81 ,
The two checkbox items are related to my change,
And I needed to discuss with you how to deal with these changes.

The logs are :

{"reqId":"E1qVs3bsCjnSHqDjNdaz","level":3,"time":"2017-04-06T23:16:10+00:00","remoteAddr":"127.0.0.1","user":"--","app":"PHP","method":"GET","url":"\/core\/cron.php","message":"Undefined index: size at \/var\/www\/core\/lib\/private\/Files\/Cache\/Scanner.php#419"}
{"reqId":"E1qVs3bsCjnSHqDjNdaz","level":3,"time":"2017-04-06T23:16:10+00:00","remoteAddr":"127.0.0.1","user":"--","app":"PHP","method":"GET","url":"\/core\/cron.php","message":"Undefined index: size at \/var\/www\/core\/lib\/private\/Files\/Cache\/Scanner.php#416"}
{"reqId":"E1qVs3bsCjnSHqDjNdaz","level":3,"time":"2017-04-06T23:16:10+00:00","remoteAddr":"127.0.0.1","user":"--","app":"PHP","method":"GET","url":"\/core\/cron.php","message":"Undefined index: size at \/var\/www\/core\/lib\/private\/Files\/Cache\/Scanner.php#419"}
{"reqId":"E1qVs3bsCjnSHqDjNdaz","level":3,"time":"2017-04-06T23:16:10+00:00","remoteAddr":"127.0.0.1","user":"--","app":"PHP","method":"GET","url":"\/core\/cron.php","message":"Undefined index: size at \/var\/www\/core\/lib\/private\/Files\/Cache\/Scanner.php#416"}
{"reqId":"E1qVs3bsCjnSHqDjNdaz","level":3,"time":"2017-04-06T23:16:10+00:00","remoteAddr":"127.0.0.1","user":"--","app":"PHP","method":"GET","url":"\/core\/cron.php","message":"Undefined index: size at \/var\/www\/core\/lib\/private\/Files\/Cache\/Scanner.php#419"}
{"reqId":"E1qVs3bsCjnSHqDjNdaz","level":3,"time":"2017-04-06T23:16:10+00:00","remoteAddr":"127.0.0.1","user":"--","app":"PHP","method":"GET","url":"\/core\/cron.php","message":"Undefined index: size at \/var\/www\/core\/lib\/private\/Files\/Cache\/Scanner.php#416"}
{"reqId":"E1qVs3bsCjnSHqDjNdaz","level":3,"time":"2017-04-06T23:16:10+00:00","remoteAddr":"127.0.0.1","user":"--","app":"PHP","method":"GET","url":"\/core\/cron.php","message":"Undefined index: size at \/var\/www\/core\/lib\/private\/Files\/Cache\/Scanner.php#419"}
{"reqId":"E1qVs3bsCjnSHqDjNdaz","level":3,"time":"2017-04-06T23:16:10+00:00","remoteAddr":"127.0.0.1","user":"--","app":"PHP","method":"GET","url":"\/core\/cron.php","message":"Undefined index: size at \/var\/www\/core\/lib\/private\/Files\/Cache\/Scanner.php#416"}
{"reqId":"E1qVs3bsCjnSHqDjNdaz","level":3,"time":"2017-04-06T23:16:10+00:00","remoteAddr":"127.0.0.1","user":"--","app":"PHP","method":"GET","url":"\/core\/cron.php","message":"Undefined index: size at \/var\/www\/core\/lib\/private\/Files\/Cache\/Scanner.php#419"}
{"reqId":"E1qVs3bsCjnSHqDjNdaz","level":3,"time":"2017-04-06T23:16:10+00:00","remoteAddr":"127.0.0.1","user":"--","app":"PHP","method":"GET","url":"\/core\/cron.php","message":"Undefined index: size at \/var\/www\/core\/lib\/private\/Files\/Cache\/Scanner.php#416"}
{"reqId":"E1qVs3bsCjnSHqDjNdaz","level":3,"time":"2017-04-06T23:16:10+00:00","remoteAddr":"127.0.0.1","user":"--","app":"PHP","method":"GET","url":"\/core\/cron.php","message":"Undefined index: size at \/var\/www\/core\/lib\/private\/Files\/Cache\/Scanner.php#419"}
{"reqId":"E1qVs3bsCjnSHqDjNdaz","level":3,"time":"2017-04-06T23:16:10+00:00","remoteAddr":"127.0.0.1","user":"--","app":"PHP","method":"GET","url":"\/core\/cron.php","message":"Undefined index: size at \/var\/www\/core\/lib\/private\/Files\/Cache\/Scanner.php#416"}
{"reqId":"E1qVs3bsCjnSHqDjNdaz","level":3,"time":"2017-04-06T23:16:10+00:00","remoteAddr":"127.0.0.1","user":"--","app":"PHP","method":"GET","url":"\/core\/cron.php","message":"Undefined index: size at \/var\/www\/core\/lib\/private\/Files\/Cache\/Scanner.php#419"}
{"reqId":"E1qVs3bsCjnSHqDjNdaz","level":3,"time":"2017-04-06T23:16:10+00:00","remoteAddr":"127.0.0.1","user":"--","app":"PHP","method":"GET","url":"\/core\/cron.php","message":"Undefined index: size at \/var\/www\/core\/lib\/private\/Files\/Cache\/Scanner.php#416"}

PVince81 · 2017-04-07T12:37:22Z

Do you observe these log entries also when running on master ? I don't see how these relate to your changes. It could be another important bug you just discovered.

noveens · 2017-04-07T12:45:43Z

@PVince81 ,
These used to appear on the latest master after the changes of #26690
When you set the flag files_external_allow_local to false in config.php, these logs still show up.

And what about the red colored indicator?

PVince81 · 2017-04-07T13:23:48Z

apps/files_external/lib/Controller/StoragesController.php

-				Http::STATUS_UNPROCESSABLE_ENTITY
-			);
-		}
+		$canCreateNewLocalStorage = \OC::$server->getConfig()->getSystemValue('files_external_allow_create_new_local', false);


move this to function create.

here you are also preventing updates to happen, so existing local storages cannot be updated/saved (red indicator)

PVince81 · 2017-04-07T13:24:48Z

BUG: need to find a way to remove "Local" from the selection list altogether, maybe filter it out when populating the list

On my local instance I didn't see any log entries related to scanner, so it might be specific to your env.

noveens · 2017-04-08T01:20:48Z

@PVince81 ,
Can you have a look?

…ow_create_new_local variable specifically set to true in config.php

noveens · 2017-04-08T13:07:28Z

@PVince81 ,

Ready for a merge?

PVince81 · 2017-04-10T06:50:52Z

apps/files_external/lib/Controller/GlobalStoragesController.php


-		$this->updateStorageStatus($newStorage);
+			$this->updateStorageStatus($newStorage);


use tabs, not spaces

Sure, will do.

@PVince81 ,
These are tabs not spaces, I guess GitHub is just trying to show the changed indentation?

PVince81 · 2017-04-10T06:51:20Z

Tested, works 👍

@noveens please fix the tabs then we can merge this

butonic · 2017-04-13T15:41:51Z

apps/files_external/lib/Controller/GlobalStoragesController.php

-		}
+		$canCreateNewLocalStorage = \OC::$server->getConfig()->getSystemValue('files_external_allow_create_new_local', false);
+
+		if ($canCreateNewLocalStorage === true) {


Unfortunately, this also triggers for smb. As it seems it prevents adding any external storage. Also it returns null and no meaningful message is shown in the web ui. Will add an issue.

PVince81 · 2017-04-13T15:52:38Z

Regression found, fixed here: #27621

lock · 2019-08-03T14:01:36Z

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

PVince81 reviewed Apr 7, 2017

View reviewed changes

noveens added 2 commits April 8, 2017 07:37

Option to mount a new local storage removed unless files_external_all…

306b43c

…ow_create_new_local variable specifically set to true in config.php

Test added, Local not showed at admin settings if config param not set

daf2c9e

noveens force-pushed the 26653 branch from a8c1b8e to daf2c9e Compare April 8, 2017 02:08

PVince81 reviewed Apr 10, 2017

View reviewed changes

PVince81 added the 3 - To Review label Apr 10, 2017

PVince81 added this to the 10.0 milestone Apr 10, 2017

PVince81 merged commit 70dd098 into master Apr 10, 2017

PVince81 deleted the 26653 branch April 10, 2017 07:51

noveens mentioned this pull request Apr 11, 2017

Checking for local external storage flag iff the method is local. #27621

Merged

9 tasks

butonic reviewed Apr 13, 2017

View reviewed changes

vkhurana mentioned this pull request Feb 3, 2018

Add option for OWNCLOUD_ALLOW_EXTERNAL_LOCAL_STORAGE owncloud-docker/base#16

Merged

lock bot locked as resolved and limited conversation to collaborators Aug 3, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Option to mount a new local storage disabled #27590

Option to mount a new local storage disabled #27590

noveens commented Apr 6, 2017 •

edited

Loading

noveens commented Apr 6, 2017 •

edited

Loading

PVince81 commented Apr 7, 2017

noveens commented Apr 7, 2017

PVince81 commented Apr 7, 2017

noveens commented Apr 7, 2017

PVince81 Apr 7, 2017

PVince81 commented Apr 7, 2017 •

edited by noveens

Loading

noveens commented Apr 8, 2017

noveens commented Apr 8, 2017

PVince81 Apr 10, 2017

noveens Apr 10, 2017

noveens Apr 10, 2017 •

edited

Loading

PVince81 commented Apr 10, 2017

butonic Apr 13, 2017

PVince81 Apr 13, 2017

PVince81 commented Apr 13, 2017

lock bot commented Aug 3, 2019


		$this->updateStorageStatus($newStorage);
		$this->updateStorageStatus($newStorage);

Option to mount a new local storage disabled #27590

Option to mount a new local storage disabled #27590

Conversation

noveens commented Apr 6, 2017 • edited Loading

Description

Related Issue

How Has This Been Tested?

Types of changes

Checklist:

noveens commented Apr 6, 2017 • edited Loading

PVince81 commented Apr 7, 2017

noveens commented Apr 7, 2017

PVince81 commented Apr 7, 2017

noveens commented Apr 7, 2017

PVince81 Apr 7, 2017

Choose a reason for hiding this comment

PVince81 commented Apr 7, 2017 • edited by noveens Loading

noveens commented Apr 8, 2017

noveens commented Apr 8, 2017

PVince81 Apr 10, 2017

Choose a reason for hiding this comment

noveens Apr 10, 2017

Choose a reason for hiding this comment

noveens Apr 10, 2017 • edited Loading

Choose a reason for hiding this comment

PVince81 commented Apr 10, 2017

butonic Apr 13, 2017

Choose a reason for hiding this comment

PVince81 Apr 13, 2017

Choose a reason for hiding this comment

PVince81 commented Apr 13, 2017

lock bot commented Aug 3, 2019

noveens commented Apr 6, 2017 •

edited

Loading

noveens commented Apr 6, 2017 •

edited

Loading

PVince81 commented Apr 7, 2017 •

edited by noveens

Loading

noveens Apr 10, 2017 •

edited

Loading