Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more automated tests to 9. Sharing #724

Merged
merged 10 commits into from
Feb 22, 2022
Merged

Add more automated tests to 9. Sharing #724

merged 10 commits into from
Feb 22, 2022

Conversation

gabi18
Copy link
Contributor

@gabi18 gabi18 commented Feb 14, 2022

Tests marked as automated on owncloud/client#9290 applied to template.

@gabi18
Copy link
Contributor Author

gabi18 commented Feb 14, 2022

@Talank The scenario for section 2/10 has to be clearer. I have removed the 🤖 here for now.
@jnweiger We have to find out what limit for file/folder names is applicable.

38 :robot: | Share a folder with user B without Create permissions enabled. Login as User B and try to create a file in it | The folder cannot be edited creating a file in it | :heavy_check_mark: | tst_sharing |
39 :robot: | Share a folder with user B without Change permissions enabled. Login as User B and try to change it | The folder cannot be changed | :heavy_check_mark: | tst_sharing |
40 :robot: | Share a folder with user B without Delete permissions enabled. Login as User B and try to delete it | The folder cannot be edited deleting files/folders in it | :heavy_check_mark: | tst_sharing |
41 :robot: | With Password Policy App enabled, Share link a file with a user and set a password that matches with the pwd policy | The file is shared with pwd |:heavy_check_mark:| tst_sharing |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that we have any test enabling password policy. Do you know any @saw-jan ?

Copy link
Contributor Author

@gabi18 gabi18 Feb 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that we have any test enabling password policy. Do you know any @saw-jan ?

These tests are marked as automated in the 2.10.0 test plan owncloud/client#9290

Copy link
Member

@saw-jan saw-jan Feb 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do have test for sharing public link with password protection but the test doesn't set any password policy on the server.

May be we misunderstood this test case and marked as automated.
If changing password policy on the server needs to be part of the test then we can automated this test.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will remove the robot from 9.2/38 - 41 for now and check which tests are needed.

@gabi18
Copy link
Contributor Author

gabi18 commented Feb 16, 2022

@Talank I have just noticed added test for long file name with a test for a file with a length of 224 chars which is supposed to work (scenario 3/5 "Long file name").
And also a test with a file length >= 233 which will fail and the file is blacklisted. For this test there isn't a scenario in the test plan yet?

@Talank
Copy link
Contributor

Talank commented Feb 17, 2022

@gabi18 I think the >=233 test was somewhere in VFS testplan 🤔 I remembered that 233 was special somehow. I don't think it was in release testplan. Can you add it though? And you can mark it automated in the PR owncloud/client#9398

@gabi18
Copy link
Contributor Author

gabi18 commented Feb 17, 2022

@gabi18 I think the >=233 test was somewhere in VFS testplan thinking I remembered that 233 was special somehow. I don't think it was in release testplan. Can you add it though? And you can mark it automated in the PR owncloud/client#9398

I have added the long file name test here as 3/6. The test in VFS testplan is about a long path name and related to placeholder creation.

If you agree I will merge this pull request now. And then mark all automated 'Files' tests in an extra step as soon as owncloud/client#9396 is finished.

@gabi18 gabi18 requested a review from Talank February 21, 2022 08:00
Copy link
Contributor

@jnweiger jnweiger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Depends on owncloud/client#9398

Technically, I approve here, but please clarify the status of the above PR before merging here. 👍

@gabi18
Copy link
Contributor Author

gabi18 commented Feb 21, 2022

@saw-jan Could you please re-check 9.2 38/39/40 - should be already automated.

I have removed 9.2/40+41 from the test plan, 9.1/24 already includes the tests with Password Policy server app.

@Talank
Copy link
Contributor

Talank commented Feb 21, 2022

Depends on owncloud/client#9398

Technically, I approve here, but please clarify the status of the above PR before merging here. +1

the PR to add automated tests for long named files has been moved to owncloud/client#9458

@saw-jan
Copy link
Member

saw-jan commented Feb 22, 2022

@saw-jan Could you please re-check 9.2 38/39/40 - should be already automated.

I have removed 9.2/40+41 from the test plan, 9.1/24 already includes the tests with Password Policy server app.

@gabi18 Yeah, we do have those tests automated.

Copy link
Contributor

@Talank Talank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gabi18 gabi18 merged commit 06e3ab6 into master Feb 22, 2022
@delete-merged-branch delete-merged-branch bot deleted the gabi18-patch-1 branch February 22, 2022 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants