Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added test for long file name #9398

Closed
wants to merge 10 commits into from

Conversation

sushmita56
Copy link
Contributor

@sushmita56 sushmita56 commented Jan 28, 2022

Related Issue

#9396

Description

The file name with length(>=233 character) is not synced and is blacklisted.

Screenshot from 2022-01-28 15-26-33

This PR has been closed due to some reason, so instead of this another PR is created here->#9458.

@CLAassistant
Copy link

CLAassistant commented Jan 28, 2022

CLA assistant check
All committers have signed the CLA.

test/gui/shared/steps/steps.py Outdated Show resolved Hide resolved
@@ -378,8 +380,7 @@ def createFile(context, filename, username=None):
f = open(join(syncPath, filename), "w")
f.write(fileContent)
f.close()



Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please revert this change back to 2 empty lines between the two step definitions/functions

def step(context, username, filenumber, foldername):
syncPath = context.userData['currentUserSyncPath']
path = join(syncPath, foldername)
snooze(5)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add comment for the reason to put snooze here. The reason is probably the same as that in create file. Nevertheless, write the comment as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Syncing all the created files at once seems to have some problem on syncing, as a result not all created files can be synced. So once a file is synced the process will have to wait unless the next file is created. So here we added a snooze of 5 seconds.

Also, the step When the user waits for the files to sync is not working properly as expected. And probably this PR -> #9442 may solve this issue. So we can’t remove snooze(5) unless the issue is fixed.

test/gui/shared/steps/steps.py Outdated Show resolved Hide resolved
test/gui/shared/steps/steps.py Outdated Show resolved Hide resolved
test/gui/shared/steps/steps.py Outdated Show resolved Hide resolved
test/gui/tst_syncing/test.feature Outdated Show resolved Hide resolved
test/gui/shared/steps/steps.py Outdated Show resolved Hide resolved
@When('user "|any|" creates a file "|any|" with size "|any|" inside the sync folder')
def step(context, username, filename, filesize):
uploadFile(context, username, filename, filesize)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

To be consistent

test/gui/tst_syncing/test.feature Outdated Show resolved Hide resolved
Examples:
| filename |
| sdkdfjsdfuidjfkdsjfksdjfksdjfksdjfksdjfksdjfkdsjfksdjfkdsjfkdsfjlsdkfjsdkjflksdjfklsdjfksdjfkdsjfkldsjfkldsjfkdsjfksdjfksdjfklsdjfklsdjflksdjflksdjfklsdjfklsdjfksdjfksdjfksdjfksdjfksdfjskdfjksdjfksdjfksdjfksdjfksdwwwwww.txt |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you create a name a bit more readable?

test/gui/tst_syncing/test.feature Show resolved Hide resolved
@jnweiger
Copy link
Contributor

@sushmita56 was this intentionally closed?

@phil-davis
Copy link
Contributor

See PR #9458

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants