-
Notifications
You must be signed in to change notification settings - Fork 665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added test for long file name #9398
Conversation
67bda19
to
a2bc6bd
Compare
25bb13d
to
d8a2a99
Compare
@@ -378,8 +380,7 @@ def createFile(context, filename, username=None): | |||
f = open(join(syncPath, filename), "w") | |||
f.write(fileContent) | |||
f.close() | |||
|
|||
|
|||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please revert this change back to 2 empty lines between the two step definitions/functions
def step(context, username, filenumber, foldername): | ||
syncPath = context.userData['currentUserSyncPath'] | ||
path = join(syncPath, foldername) | ||
snooze(5) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add comment for the reason to put snooze here. The reason is probably the same as that in create file. Nevertheless, write the comment as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Syncing all the created files at once seems to have some problem on syncing, as a result not all created files can be synced. So once a file is synced the process will have to wait unless the next file is created. So here we added a snooze of 5 seconds.
Also, the step When the user waits for the files to sync
is not working properly as expected. And probably this PR -> #9442 may solve this issue. So we can’t remove snooze(5)
unless the issue is fixed.
@When('user "|any|" creates a file "|any|" with size "|any|" inside the sync folder') | ||
def step(context, username, filename, filesize): | ||
uploadFile(context, username, filename, filesize) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be consistent
…ent extensions sync correctly or not
bd82c73
to
3c17b3a
Compare
Examples: | ||
| filename | | ||
| sdkdfjsdfuidjfkdsjfksdjfksdjfksdjfksdjfksdjfkdsjfksdjfkdsjfkdsfjlsdkfjsdkjflksdjfklsdjfksdjfkdsjfkldsjfkldsjfkdsjfksdjfksdjfklsdjfklsdjflksdjflksdjfklsdjfklsdjfksdjfksdjfksdjfksdjfksdfjskdfjksdjfksdjfksdjfksdjfksdwwwwww.txt | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you create a name a bit more readable?
@sushmita56 was this intentionally closed? |
See PR #9458 |
Related Issue
#9396
Description
The file name with length(>=233 character) is not synced and is blacklisted.
This PR has been closed due to some reason, so instead of this another PR is created here->#9458.