Skip to content
This repository has been archived by the owner on Mar 19, 2024. It is now read-only.

[New arch] Insert public share for file #240

Merged
merged 5 commits into from
Apr 4, 2019

Conversation

davigonz
Copy link
Contributor

@davigonz davigonz commented Feb 25, 2019

Implement owncloud/android#2450
Needs owncloud/android#2461

[QA ]Checks performed after automatic tests: #240 (comment)

@davigonz davigonz self-assigned this Feb 25, 2019
@davigonz davigonz changed the title [New arch] Insert public share for file [New arch] Insert public share for file [WIP] Feb 25, 2019
@davigonz davigonz force-pushed the new_arch/insert_public_share_for_file branch 3 times, most recently from a862c02 to 16383c9 Compare March 6, 2019 09:41
@davigonz davigonz changed the base branch from master to new_arch/shares March 13, 2019 12:48
@davigonz davigonz force-pushed the new_arch/insert_public_share_for_file branch from 0c07687 to 324b6dc Compare March 13, 2019 17:46
@davigonz davigonz force-pushed the new_arch/insert_public_share_for_file branch from 324b6dc to 3d6359c Compare March 15, 2019 13:58
@davigonz davigonz requested review from hosy and hannesa2 March 21, 2019 09:39
@davigonz davigonz changed the title [New arch] Insert public share for file [WIP] [New arch] Insert public share for file Mar 21, 2019
@jesmrec
Copy link
Collaborator

jesmrec commented Apr 3, 2019

Some small tests performed here, so the main feature is covered with automatic tests:

  • Files:

  • Create share with name

  • Create share without name

  • Create share with password

  • Create share with expiration

  • Create share with all options

  • Create share with error (item not in server anymore)

  • Folders:

  • Create share with name

  • Create share without name

  • Create share Download/view

  • Create share Download/view/upload

  • Create share Upload only

  • Create share with password

  • Create share with expiration

  • Create share with all options

  • Create share with error (item not in server anymore)

Capabilities are not supported yet (check owncloud/android#2495)

@jesmrec jesmrec self-assigned this Apr 3, 2019
@davigonz davigonz merged commit af7cca0 into new_arch/shares Apr 4, 2019
@delete-merged-branch delete-merged-branch bot deleted the new_arch/insert_public_share_for_file branch April 4, 2019 12:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants