Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New architecture] Capabilities #2495

Closed
20 of 21 tasks
davigonz opened this issue Mar 21, 2019 · 2 comments
Closed
20 of 21 tasks

[New architecture] Capabilities #2495

davigonz opened this issue Mar 21, 2019 · 2 comments

Comments

@davigonz
Copy link
Contributor

davigonz commented Mar 21, 2019

The sooner we have capabilities within the new architecture the better since some of the app features depend on them:

  • Shares.
  • RefreshFolderOp.
  • FileMenuFilter.

2  Capabilities


TASKS

  • Create OCCapability entity
  • Create OCCapabilityDAO with query to get and insert capabilities
  • Create OCCapabilityLocalDataSource and OCCapabilityRemoteDataSource
  • Create OCCapabilityRepository
  • Create OCCapabilityViewModel
  • Use LiveData in CapabilityDAO
  • Get and insert capabilities when needed
  • Error handling
  • Expose capabilities stored in room by using Content Provider => Not possible yet since capabilities are being used from other parts of the code not related to sharing, we will keep capabilities on old and new databases.
  • Database migration
  • Unit tests:
    • OCCapabilityViewModel
    • OCCapabilityLocalDataSource
    • OCCapabilityRemoteDataSource
    • OCCapabilityRepository
  • Instrumented tests:
    • CapabilityContentProvider
    • OCCapabilityDAO
  • UI tests

PRs

App: #2508
Library: owncloud/android-library#246

@jesmrec
Copy link
Collaborator

jesmrec commented Apr 11, 2019

Test plan for UI tests linked in header message. @davigonz you can check if you miss something.

@davigonz davigonz reopened this Apr 17, 2019
@jesmrec
Copy link
Collaborator

jesmrec commented Apr 22, 2019

Tested password policy app with the new architecture implementation. Everything is OK, currently, if the password created under some policies does not match, an error message is shown with the specific error pointing the user to change it to match every policy.

Number of expiration days depending on the public link password are also correctly managed.

CC @michaelstingl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants