New arch/capabilities #2508

davigonz · 2019-04-02T11:03:08Z

Implements #2495
Needs owncloud/android-library#246

Bugs & improvements

(1) Not refreshed New arch/capabilities #2508 (comment) [FIXED] @jesmrec
(2) "Allow users to share via link" not refreshed the first time New arch/capabilities #2508 (comment) [FIXED] @jesmrec

…ent provider and modify capability insert method to use lists

…es and use them in UI tests

…bilities

owncloudApp/src/androidTest/java/com/owncloud/android/shares/ui/ShareFileFragmentTest.kt

owncloudApp/src/main/java/com/owncloud/android/capabilities/db/OCCapability.kt

owncloudApp/src/main/java/com/owncloud/android/capabilities/db/OCCapabilityDao.kt

owncloudApp/src/test/java/com/owncloud/android/NetworkBoundResourceTest.kt

...c/test/java/com/owncloud/android/capabilities/repository/RemoteCapabilitiesDataSourceTest.kt

abelgardep · 2019-04-25T11:54:42Z

@davigonz Some changes requested

davigonz · 2019-04-26T08:05:26Z

@abelgardep changes applied

owncloudApp/src/main/java/com/owncloud/android/shares/ui/fragment/ShareFileFragment.kt

owncloudApp/src/main/java/com/owncloud/android/shares/viewmodel/OCShareViewModel.kt

...loudApp/src/main/java/com/owncloud/android/capabilities/repository/OCCapabilityRepository.kt

...src/main/java/com/owncloud/android/capabilities/datasource/OCRemoteCapabilitiesDataSource.kt

davigonz · 2019-04-29T10:24:54Z

Code approved, ready to test @jesmrec , great job @abelgardep with the code review

jesmrec · 2019-05-02T11:24:53Z

(1) [FIXED]

Capabilities are not being refresh after opening share view.

For example, if in UI you enable "Allow users to share via link", after opening share view, the "Public Share" section is visible.

Same happens with the password enforcing options.

jesmrec · 2019-05-03T10:11:56Z

(2) [FIXED]

Check these steps:

Disable feature "Allow users to share via link" in web dashboard
Open share for any item -> Public sharing is hidden (OK)
Go back to file list
Enable feature "Allow users to share via link" in web dashboard and pull down to refresh
Share again an item

Current: feature was enabled but public link section keeps hidden. By going back again to file list, and re-opening share, everything is correct. Seems that the first opening refresh capabilities, but do not apply changes in UI.

Nexus 6P v7

NOTE: the mentioned capability is the only affected. Any other capability related to public sharing is working as expected.

davigonz · 2019-05-03T13:06:55Z

@jesmrec #2508 (comment) is ready to test but you will notice the public link section disappearing every time you open the shares view when Allow users to share via link option is disabled.

I do not like how it looks honestly, but since we are getting capabilities from network when opening the sharing view, there's nothing else we can do in terms of UI.

Maybe we can improve this behaviour during the implementation of capabilities when refreshing folders and just get capabilities from the database instead of server on the sharing view.

michaelstingl · 2019-05-03T13:58:49Z

the public link section disappearing every time you open the shares view when Allow users to share via link option is disabled.

Could you post a GIF?

davigonz · 2019-05-06T07:34:52Z

the public link section disappearing every time you open the shares view when Allow users to share via link option is disabled.

Could you post a GIF?

michaelstingl · 2019-05-06T08:31:58Z

Ah, got it. Reverse it? Disabling items (empty for a few milliseconds), and enable only those that are valid?

davigonz · 2019-05-06T08:54:41Z

Ah, got it. Reverse it? Disabling items (empty for a few milliseconds), and enable only those that are valid?

I kept it that way because I thought users will likely have the public shares enabled instead of disabled and the effect would not appear most of the times.

jesmrec · 2019-05-06T10:37:17Z

yes, it is not usual that the capabilities are changing standly, they use to be static. Fix is correct.

Approved.

Create OCCapability entity, DAO and datasources

564186f

davigonz mentioned this pull request Apr 2, 2019

New arch/capabilities owncloud/android-library#246

Merged

davigonz changed the title ~~New arch/capabilities~~ New arch/capabilities [WIP] Apr 2, 2019

davigonz mentioned this pull request Apr 2, 2019

[New architecture] Capabilities #2495

Closed

21 tasks

davigonz added 4 commits April 5, 2019 10:22

Create OCCapabilityRepository

dea1c6d

Include OCCapabilityViewModel

9c51b78

Load capabilities from ShareFileFragment [WIP]

2eb9756

Use capabilities from ShareFileFragment

6b26d17

davigonz changed the base branch from master to new_arch/shares April 8, 2019 12:34

Accept pending licenses

5ce92e9

davigonz force-pushed the new_arch/shares branch from f82ba8c to 852c46c Compare April 9, 2019 08:23

davigonz force-pushed the new_arch/capabilities branch from dc9921a to 01977a3 Compare April 9, 2019 16:25

Rebase library with new_arch/shares

fb56ffd

davigonz force-pushed the new_arch/capabilities branch from 01977a3 to fb56ffd Compare April 9, 2019 16:54

davigonz force-pushed the new_arch/shares branch 2 times, most recently from 98722e0 to f82ba8c Compare April 9, 2019 17:10

davigonz and others added 11 commits April 10, 2019 10:45

Get and insert capabilities when needed

09200ea

Include tests for CapabilityContentProvider

6804c24

Fix share unit tests

163bcf6

OCCapabilityViewModel tests

f7ebfd5

Include capability datasources tests

f45a584

Include tests in OCCapabilityRepository

0824fa9

Include OCCapabilityDao tests, revert capability changes in file cont…

d4b6371

…ent provider and modify capability insert method to use lists

Fix some public share tests and prepare the code to inject capabiliti…

f2a5564

…es and use them in UI tests

Add more UI tests for capabilities

cade17d

Add expiration date UI tests to cover public share creation with capa…

63fb47e

…bilities

extend capabilities tests

aec2f8c

davigonz requested review from jesmrec and abelgardep April 16, 2019 10:09

davigonz changed the title ~~New arch/capabilities [WIP]~~ New arch/capabilities Apr 16, 2019

add capability ViewModel to shareFragment in ShareFolderFragmentTest

ea4652a

abelgardep suggested changes Apr 25, 2019

View reviewed changes

Apply CR changes

8ab4b98

abelgardep suggested changes Apr 26, 2019

View reviewed changes

More CR changes

28d8068

abelgardep approved these changes Apr 29, 2019

View reviewed changes

davigonz added the code approved label Apr 29, 2019

davigonz mentioned this pull request Apr 29, 2019

[New arch] App modularization and decoupling #2523

Closed

Fix capabilities not refreshed

15fd0f2

Fix Allow users to share via link not refreshed the first time

9a018dd

jesmrec added the Approved by qa label May 6, 2019

jesmrec approved these changes May 6, 2019

View reviewed changes

davigonz merged commit e650c82 into new_arch/shares May 6, 2019

delete-merged-branch bot deleted the new_arch/capabilities branch May 6, 2019 10:40

davigonz mentioned this pull request Jul 29, 2019

Welcome new Android components and architecture #2351

Open

19 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New arch/capabilities #2508

New arch/capabilities #2508

davigonz commented Apr 2, 2019 •

edited by jesmrec

Loading

abelgardep commented Apr 25, 2019

davigonz commented Apr 26, 2019

davigonz commented Apr 29, 2019 •

edited

Loading

jesmrec commented May 2, 2019 •

edited

Loading

jesmrec commented May 3, 2019 •

edited

Loading

davigonz commented May 3, 2019

michaelstingl commented May 3, 2019

davigonz commented May 6, 2019

michaelstingl commented May 6, 2019

davigonz commented May 6, 2019

jesmrec commented May 6, 2019

New arch/capabilities #2508

New arch/capabilities #2508

Conversation

davigonz commented Apr 2, 2019 • edited by jesmrec Loading

abelgardep commented Apr 25, 2019

davigonz commented Apr 26, 2019

davigonz commented Apr 29, 2019 • edited Loading

jesmrec commented May 2, 2019 • edited Loading

(1) [FIXED]

jesmrec commented May 3, 2019 • edited Loading

(2) [FIXED]

davigonz commented May 3, 2019

michaelstingl commented May 3, 2019

davigonz commented May 6, 2019

michaelstingl commented May 6, 2019

davigonz commented May 6, 2019

jesmrec commented May 6, 2019

davigonz commented Apr 2, 2019 •

edited by jesmrec

Loading

davigonz commented Apr 29, 2019 •

edited

Loading

jesmrec commented May 2, 2019 •

edited

Loading

jesmrec commented May 3, 2019 •

edited

Loading