[New arch] OCFileListFragment isolation

[abelgardep]

Currently, there are several fragments to list files, it would be great to unify them and get rid of activities dependencies.

(Good to have) Adapter refactors, use a recycler view to show the list of files, use diff util to increase performance, use already created FilesViewModel, get files from DB as Flow and Pagination for better performance.

Tasks

• Create branch new_arch/file_list_isolation
• Development tasks
  • New fragment MainFileListFragment Simple list have been created. #3451
  • New ViewModel (?) Simple list have been created. #3451
  • Show a simple list of files (GetFolderContentUseCase it will be updated to LiveData-Flow) Simple list have been created. #3451 Retrieve data from DB as LiveData has been implemented. #3461
  • Footer with number of files and folders New arch/footer and other changes #3457
  • Empty files view (Could be modified -> [FEATURE REQUEST] Improve empty views #3026) New arch/empty folder #3460
  • Swipe to refresh (call RefreshFolderFromServerAsyncUseCase) Swipe to Refresh #3469
  • Different options: All files, Shared by link and Av Offline (FileListOption -> Check if we can improve it) ( GetFilesSharedByLinkUseCase) (AvOffline use case does not exist yet) -> New arch/shared files #3471
  • Bottom navigation bar -> New arch/bottom nav bar #3476
  • Grid view mode Grid view mode #3493
  • Floating action button handling (Only shown in All files option) -> New arch/fab handling #3492
  • Search files within the list (Check if a new use case is needed for this. It is searched locally and only for this folder) -> New arch/search inside folder #3494
  • Sort by name, size, and date (Check if a new use case is needed for this) Sort by name, size, and date #3478
  • Consider adding diff util to improve performance
  • Display images correctly in the list The images are displayed correctly in the list. #3495
  • Multiselection
    • Change toolbar
      • Control items selected Selected items controlled and hide/show FAB button #3508
      • Control checkbox -> New arch/multiselecton menu options #3545
      • Control Drawer Status of Navigation Drawer controlled when multiselection is enabled or disabled #3511
      • Refresh option -> New arch/multiselecton menu options #3545
      • Share option -> New arch/multiselecton menu options #3545
    • Show Menu Dialog (Keep in mind that we may change the UI -> [FEATURE REQUEST] Show "More" button for every file list item #2885)
      • Select all -> New arch/multiselecton menu options #3545
      • Select inverse -> New arch/multiselecton menu options #3545
      • Set as Av. Offline
      • Move -> New arch/multiselecton menu options #3545
      • Copy -> New arch/multiselecton menu options #3545
      • Rename -> New arch/multiselecton menu options #3545
      • Remove -> New arch/multiselecton menu options #3545
    • Hide FAB Selected items controlled and hide/show FAB button #3508
    • Manage actionMode after an operation is executed (in order to hide it)
  • Testing

Check if it would be feasible to use this fragment to show the file list in ReceiveExternalFilesActivity

• Retrieve files in a flow or live data to get auto-updates (new usecase, add it to repository, dao, local datasource)
• Code review and apply changes requested
• Design test plan
• QA
• Merge branch feature/feature_name into master

Bugs to fix:

• Control popBackStack() when the user navigates inside the folder. New arch/navigation #3503
• Avoid crash when the user uses the application in portrait or landscape mode and performs a search. Fixed Footer Bug #3501
• Avoid crash when the application is installed from scratch with the new architecture. Avoid launch request list of files when there is not a logged account #3504
• Display the correct list when the user navigates through the bottom menu. Displayed the correct list when the user navigates through the bottom nav bar. #3505
• Control filtering on all screens. Filtering has been controlled on all screens #3502
• When a file or folder is shared, icon is not updated to show link
• Manage click on files (not folders) to download them Manage click on files (not folders) to download them implemented #3555
• All folders are empty, even if they contain data.
• Change toolbar name
• When user rotates the device, the folder root is reset
• Back arrow button does not work correctly in the toolbar
• Multiselection toolbar doesn't show correct icons
• Footer is gone

[fesave]

device-2021-12-14-092239.mp4

We want to propose a change of functionality taking advantage of the task of re-architecting the application. As you can see in the video, currently the type of view (List or Grid) is configured by folder and not globally. We believe that if it were configured globally it would be easier to use for the user, because right now he must go folder by folder configuring his desired view type. We have seen that other apps work this way and we think it is simpler and would help us to simplify the code. What do you think?

cc @michaelstingl @tbsbdr @hosy @jesmrec @abelgardep @JuancaG05

[tbsbdr]

afaik ux-wise there is no "standard" expected behaviour if the view-setting should be set "per single folder" or "globally" (looking at windows explorer, mac os finder; mobile apps: dropbox, box, onedrive, google drive - no consistent behaviour if the view settings are set "per single folder" or "globally"). both approaches are legit.
I would be fine with setting it globally and would then also implement it this way for the web ui.

[abelgardep]

Known issues (8b38cb3)

• Duplicated items after uploads. Check if it is a new problem or a problem that will be fixed within the uploads issue [New Arch] Uploads #3004
• Av. Offline and shared-by-link shortcuts don't work properly. To be done within [New arch] Av. Offline #3246

[abelgardep]

Let's close the issue, known issues will be fixed in upcoming PRs