Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New arch/footer and other changes #3457

Merged
merged 7 commits into from
Nov 23, 2021
Merged

New arch/footer and other changes #3457

merged 7 commits into from
Nov 23, 2021

Conversation

jabarros
Copy link
Contributor

Related Issues

App:

Library PR (if needed):

  • Added changelog files for the fixed issues in folder changelog/unreleased. More info here

QA

@sonarcloud
Copy link

sonarcloud bot commented Nov 23, 2021

SonarCloud Quality Gate failed.    Quality Gate failed

Bug E 864 Bugs
Vulnerability C 18 Vulnerabilities
Security Hotspot E 26 Security Hotspots
Code Smell A 5234 Code Smells

0.0% 0.0% Coverage
3.7% 3.7% Duplication

fesave
fesave approved these changes Nov 23, 2021
View reviewed changes
Copy link
Contributor

@fesave fesave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fesave fesave merged commit 14c8d04 into new_arch/file_list_isolation Nov 23, 2021
@fesave fesave deleted the new_arch/footer_and_other_changes branch November 23, 2021 16:19
@jabarros jabarros mentioned this pull request Nov 24, 2021
Closed
52 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fesave fesave fesave approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jabarros @fesave