Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Footer Bug #3501

Merged
merged 2 commits into from
Jan 17, 2022
Merged

Fixed Footer Bug #3501

merged 2 commits into from
Jan 17, 2022

Conversation

fesave
Copy link
Contributor

@fesave fesave commented Jan 17, 2022

QA

@fesave fesave mentioned this pull request Jan 17, 2022
Closed
52 tasks
@sonarcloud
Copy link

sonarcloud bot commented Jan 17, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug E 221 Bugs
Vulnerability C 18 Vulnerabilities
Security Hotspot E 26 Security Hotspots
Code Smell A 5352 Code Smells

0.0% 0.0% Coverage
4.3% 4.3% Duplication

jabarros
jabarros reviewed Jan 17, 2022
View reviewed changes
...pp/src/main/java/com/owncloud/android/presentation/ui/files/filelist/MainFileListFragment.kt Outdated

fileListAdapter.notifyItemRangeChanged(0, fileListAdapter.itemCount)
}

private fun setFooterCorrectly(isListMode: Boolean) {
/*private fun setFooterCorrectly(isListMode: Boolean) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this code not needed since now? Can we remove it and the places where this method is asked for?

@jabarros jabarros merged commit 37a2007 into new_arch/file_list_isolation Jan 17, 2022
@jabarros jabarros deleted the new_arch/fix_footer_bug branch January 17, 2022 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jabarros jabarros jabarros left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fesave @jabarros