Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[New arch] Complete login #2826

Merged
merged 49 commits into from
Apr 14, 2020
Merged

[New arch] Complete login #2826

merged 49 commits into from
Apr 14, 2020

Commits on Feb 20, 2020

  1. Create GetUserInfoUseCase

    @abelgardep
    abelgardep committed Feb 20, 2020
    Configuration menu
    Copy the full SHA
    e7546a3 View commit details
    Browse the repository at this point in the history

  2. Start working on login usecase

    @abelgardep
    abelgardep committed Feb 20, 2020
    Configuration menu
    Copy the full SHA
    678ab19 View commit details
    Browse the repository at this point in the history

  3. Rename remote operations

    @abelgardep
    abelgardep committed Feb 20, 2020
    Configuration menu
    Copy the full SHA
    880c628 View commit details
    Browse the repository at this point in the history

  4. WIP AuthenticationActivity Refactorization

    @abelgardep
    abelgardep committed Feb 20, 2020
    Configuration menu
    Copy the full SHA
    73b29c2 View commit details
    Browse the repository at this point in the history

  5. Keep working on LoginActivity

    @abelgardep
    abelgardep committed Feb 20, 2020
    Configuration menu
    Copy the full SHA
    79c4a81 View commit details
    Browse the repository at this point in the history

  6. Update login button status

    @abelgardep
    abelgardep committed Feb 20, 2020
    Configuration menu
    Copy the full SHA
    72d846b View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2020

  1. Replace username and password EditText with TextInputLayout

    @abelgardep
    abelgardep committed Feb 21, 2020
    Configuration menu
    Copy the full SHA
    b7bee86 View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2020

  1. Complete first basic flow. Pending on account save

    @abelgardep
    abelgardep committed Feb 24, 2020
    Configuration menu
    Copy the full SHA
    8e1748e View commit details
    Browse the repository at this point in the history

Commits on Feb 25, 2020

  1. Fix icons not showing on login landscape mode and theme glitch

    @abelgardep
    abelgardep committed Feb 25, 2020
    Configuration menu
    Copy the full SHA
    7d71346 View commit details
    Browse the repository at this point in the history

  2. Handle login screen rotation

    @abelgardep
    abelgardep committed Feb 25, 2020
    Configuration menu
    Copy the full SHA
    55097ab View commit details
    Browse the repository at this point in the history

Commits on Feb 26, 2020

  1. Create account handling methods within LocalAuthenticationDataSource … 

    …[WIP]
    @davigonz
    davigonz committed Feb 26, 2020
    Configuration menu
    Copy the full SHA
    da16dd8 View commit details
    Browse the repository at this point in the history

  2. Add account creation methods to OCLocalAuthenticationDataSource

    @davigonz
    davigonz committed Feb 26, 2020
    Configuration menu
    Copy the full SHA
    7234ab7 View commit details
    Browse the repository at this point in the history

  3. Polish brandable options on LoginActivity

    @abelgardep
    abelgardep committed Feb 26, 2020
    Configuration menu
    Copy the full SHA
    1cb6c98 View commit details
    Browse the repository at this point in the history

  4. Provides AuthenticationRepository with enough information to save the… 

    … account into Account Manager
    @abelgardep
    abelgardep committed Feb 26, 2020
    Configuration menu
    Copy the full SHA
    74ec4a1 View commit details
    Browse the repository at this point in the history

  5. Start using new LoginActivity, create account after login

    @davigonz
    davigonz committed Feb 26, 2020
    Configuration menu
    Copy the full SHA
    5143326 View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2020

  1. Multiaccount with new LoginActivity

    @davigonz
    davigonz committed Feb 27, 2020
    Configuration menu
    Copy the full SHA
    a001db5 View commit details
    Browse the repository at this point in the history

  2. OAuth with new arch, initial commit

    @davigonz
    davigonz committed Feb 27, 2020
    Configuration menu
    Copy the full SHA
    ce3acff View commit details
    Browse the repository at this point in the history

  3. Create usecase for getting user data and handle authTokenType during … 

    …rotations
    @davigonz
    davigonz committed Feb 27, 2020
    Configuration menu
    Copy the full SHA
    c6377a9 View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2020

  1. Keep account dependencies in app and data modules

    @davigonz
    davigonz committed Feb 28, 2020
    Configuration menu
    Copy the full SHA
    244a7b4 View commit details
    Browse the repository at this point in the history

  2. Complete OAuth login flow

    @davigonz
    davigonz committed Feb 28, 2020
    Configuration menu
    Copy the full SHA
    a28c791 View commit details
    Browse the repository at this point in the history

Commits on Mar 2, 2020

  1. First LoginActivity UI tests

    @abelgardep
    abelgardep committed Mar 2, 2020
    Configuration menu
    Copy the full SHA
    f9b4f33 View commit details
    Browse the repository at this point in the history

  2. Prepare new LoginActivity to be used where old AuthenticatorActivity … 

    …was being used, e.g. reauthentication after authorization expiration [WIP]
    @davigonz
    davigonz committed Mar 2, 2020
    Configuration menu
    Copy the full SHA
    6e1299d View commit details
    Browse the repository at this point in the history

  3. Fix da translation that was triggering a lint failure

    @davigonz
    davigonz committed Mar 2, 2020
    Configuration menu
    Copy the full SHA
    3d129f6 View commit details
    Browse the repository at this point in the history

Commits on Mar 3, 2020

  1. Write base url in LoginActivity when an account needs to be reauthent… 

    …icated
    @davigonz
    davigonz committed Mar 3, 2020
    Configuration menu
    Copy the full SHA
    0a22428 View commit details
    Browse the repository at this point in the history

  2. Accounts update [WIP]

    @davigonz
    davigonz committed Mar 3, 2020
    Configuration menu
    Copy the full SHA
    f7a9840 View commit details
    Browse the repository at this point in the history

  3. Include ViewModel extension to run different types of usecases and ge… 

    …t rid of main dispatchers when posting values in livedata
    @davigonz
    davigonz committed Mar 3, 2020
    Configuration menu
    Copy the full SHA
    d35a80a View commit details
    Browse the repository at this point in the history

  4. Test oB options

    @abelgardep
    abelgardep committed Mar 3, 2020
    Configuration menu
    Copy the full SHA
    dec5fe3 View commit details
    Browse the repository at this point in the history

  5. Do not call viewmodel if url is empty

    @abelgardep
    abelgardep committed Mar 3, 2020
    Configuration menu
    Copy the full SHA
    18e65d7 View commit details
    Browse the repository at this point in the history

  6. Update OAuth and basic accounts; remove old AuthenticatorActivity

    @davigonz
    davigonz committed Mar 3, 2020
    Configuration menu
    Copy the full SHA
    d9b4b80 View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2020

  1. Add tests for OCAuthenticationRepositoryTest, OCLocalAuthentionDataSo… 

    …urceTest and some improvements in viewmodel extensions
    @davigonz
    davigonz committed Mar 4, 2020
    Configuration menu
    Copy the full SHA
    af31b65 View commit details
    Browse the repository at this point in the history

  2. Remove old operations

    @abelgardep
    abelgardep committed Mar 4, 2020
    Configuration menu
    Copy the full SHA
    b999423 View commit details
    Browse the repository at this point in the history

  3. Complete basic and OAuth account creation and update tests

    @davigonz
    davigonz committed Mar 4, 2020
    Configuration menu
    Copy the full SHA
    01e09af View commit details
    Browse the repository at this point in the history

  4. Keep working in loginActivity UI tests

    @abelgardep
    abelgardep committed Mar 4, 2020
    Configuration menu
    Copy the full SHA
    b4860ae View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2020

  1. Add more tests for authentication usecases

    @davigonz
    davigonz committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    8206a74 View commit details
    Browse the repository at this point in the history

  2. Move services to library so that library users can use them

    @davigonz
    davigonz committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    0294d62 View commit details
    Browse the repository at this point in the history

  3. Fix ui tests

    @abelgardep
    abelgardep committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    4ee111d View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2020

  1. Continue working on UI tests

    @abelgardep
    abelgardep committed Mar 6, 2020
    Configuration menu
    Copy the full SHA
    c6bb15c View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2020

  1. Polish LoginActivityTest

    @abelgardep
    abelgardep committed Mar 9, 2020
    Configuration menu
    Copy the full SHA
    65e8cdb View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2020

  1. Apply CR changes

    @davigonz
    davigonz committed Mar 16, 2020
    Configuration menu
    Copy the full SHA
    8fe6254 View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2020

  1. Fix Username editable in OAuth2 account edition

    @davigonz
    davigonz committed Mar 18, 2020
    Configuration menu
    Copy the full SHA
    917d475 View commit details
    Browse the repository at this point in the history

  2. Fix Turning device to landscape, becomes the username field editable

    @davigonz
    davigonz committed Mar 18, 2020
    Configuration menu
    Copy the full SHA
    90bb312 View commit details
    Browse the repository at this point in the history

  3. Fix redirections and a little cleanup

    @abelgardep
    abelgardep committed Mar 18, 2020
    Configuration menu
    Copy the full SHA
    0356daf View commit details
    Browse the repository at this point in the history

  4. Show specific message when service is unavailable

    @abelgardep
    abelgardep committed Mar 18, 2020
    Configuration menu
    Copy the full SHA
    9f917bb View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2020

  1. Assert connectivity before performing a network operation and update … 

    …tests
    @abelgardep
    abelgardep committed Mar 19, 2020
    Configuration menu
    Copy the full SHA
    9015b7f View commit details
    Browse the repository at this point in the history

  2. Replace old icons with vectorized ones

    @abelgardep
    abelgardep committed Mar 19, 2020
    Configuration menu
    Copy the full SHA
    555b928 View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2020

  1. Add pending test

    @abelgardep
    abelgardep committed Apr 6, 2020
    Configuration menu
    Copy the full SHA
    2c2b816 View commit details
    Browse the repository at this point in the history

Commits on Apr 7, 2020

  1. Fix and add remaining tests

    @abelgardep
    abelgardep committed Apr 7, 2020
    Configuration menu
    Copy the full SHA
    69af7fc View commit details
    Browse the repository at this point in the history

  2. Update text when server certificate is not trusted

    @abelgardep
    abelgardep committed Apr 7, 2020
    Configuration menu
    Copy the full SHA
    6856d99 View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2020

  1. Update icon and text when server certificate is not trusted

    @abelgardep
    abelgardep committed Apr 8, 2020
    Configuration menu
    Copy the full SHA
    591d5d1 View commit details
    Browse the repository at this point in the history