Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix initial size of share dialoig #8506

Closed
wants to merge 1 commit into from

Conversation

TheOneRing
Copy link
Member

@mmattel could you give the build artifact a try to see whether it fixes your issue?

@sonarcloud
Copy link

sonarcloud bot commented Mar 22, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@mmattel
Copy link
Contributor

mmattel commented Mar 22, 2021

give the build artifact a try

can you give me a jump start what this means and how to try it?

@mmattel
Copy link
Contributor

mmattel commented Mar 22, 2021

If it works, will fix #8366

@TheOneRing
Copy link
Member Author

Go to https://github.com/owncloud/client/actions/runs/675876872 download a windows artifact, don't try to run the installer but just extract the contained .7z for example owncloud-client-HEAD-9d921dea8-2.8-windows-msvc2017_64-cl.7z

Make sure owncloud is not running and run the owncloud.exe form that directory, check the about page to ensure your running the right build :)

@mmattel
Copy link
Contributor

mmattel commented Mar 22, 2021

I tested with the artifact you provided. To get a better impression, I moved the mouse to the taskbar for the screenshot to make the size of the screen more visible. This is how it looks directly after opening the share dialog for the file. I CANNOT reduce the height of the sharing window = smallest size. IMHO there should be a dynamic math behind the screen height with a min value but dependent on the screen height. Just my 2c

@TheOneRing
Copy link
Member Author

Thx for the screenshot ....
For some reason we set a fixed size for the warning label.
You issue probably also only occurrences when sharing from that share.

@TheOneRing
Copy link
Member Author

Hmm no, I can resize it....
image

@mmattel
Copy link
Contributor

mmattel commented Mar 22, 2021

This is strange. I am using W10x64 latest build an patches but this issue is present for some time now. And all other programs I use do not have this issue.


The interesting thing is, that I can resize the window horizontally, so something must be set to disable it vertically. You see in the image shown the minimum horizontal size I can shrink to:

@TheOneRing
Copy link
Member Author

Fixed in 2.9

@TheOneRing TheOneRing closed this Aug 23, 2021
@TheOneRing TheOneRing deleted the work/fix_sharedialog_size branch January 28, 2022 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants