Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Share window: vertical window resize not possible #8366

Closed
mmattel opened this issue Jan 17, 2021 · 15 comments · Fixed by #8874
Closed

Share window: vertical window resize not possible #8366

mmattel opened this issue Jan 17, 2021 · 15 comments · Fixed by #8874
Labels
Milestone

Comments

@mmattel
Copy link
Contributor

mmattel commented Jan 17, 2021

When using the context menu to share an item, a window opens to do so. This window is quite large and can´t be vertically resized. Having a standard Full HD resolution 1920x1080, the window is so big, that it is hard to get it fully visible. Trying to resize it is not possible. This is not a good solution. The window should be vertically resizeable (with a minimum size eg, half the size of the vertical resolution) and a scrollbar should be added if the actual size is lower than the needed one to show all elements.

Expected behaviour

Vertical window resize possible

Actual behaviour

Vertical window resize not possible

Steps to reproduce

  1. Open share settings via context menu

Client configuration

Client version: 2.7.4

Operating system: W10x64Pro

OS language: DE

@TheOneRing
Copy link
Member

That's not how it is supposed to look like, and while the Window can be enlarged it can't be reduced below its initial value.
What you describe sounds like a hdpi scaling issue, are you using a hdpi laptop with a 1080 screen attached?

image

@mmattel
Copy link
Contributor Author

mmattel commented Jan 18, 2021

@TheOneRing
I am using a Fujitsu Lifebook U748, see the specs at: https://www.fujitsu.com/fts/products/computing/pc/notebooks/lifebook-u748/
No external monitor used.
The middle field as shown in your image above is so big, that you run into the issue described.

Q: Why not having the content in a frame and if the frame fits into the physical screen no scrollbar is shown and if it does not fit a scrollbar shows up - and you can resize the window down to a min height which is always half of the physical screen height?

@TheOneRing
Copy link
Member

In the first place the dialog should not get as big as you describe it :D
And yes it should allow resizes :D

@github-actions
Copy link

This issue was marked stale because it has been open for 30 days with no activity. Remove the stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Feb 18, 2021
@mmattel
Copy link
Contributor Author

mmattel commented Feb 18, 2021

@TheOneRing any progress on that?

@TheOneRing
Copy link
Member

Do you have many recipients or is there any reason why that should grow that big?
Could you send a screenshot to apps@owncloud.com :)

@mmattel
Copy link
Contributor Author

mmattel commented Feb 18, 2021

It is the initial screen having NO sharees = list is empty...

@TheOneRing
Copy link
Member

I don't see how the dialog should become that big.
The dialog can be resized, but not below a minimum size.
The minimum size is supposed to be lower than what you describe.

Scroll bars don't solve all problems and cause some #7043 .

@mmattel
Copy link
Contributor Author

mmattel commented Feb 18, 2021

The following screenshot is the SMALLEST size I can get on my screen. Intel UHD 1920x1080x60Hz.
Pls see that this is defacto close to full height and can´t be downsized!
image

@github-actions github-actions bot removed the Stale label Feb 19, 2021
@github-actions
Copy link

This issue was marked stale because it has been open for 30 days with no activity. Remove the stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Mar 21, 2021
@mmattel
Copy link
Contributor Author

mmattel commented Mar 21, 2021

Issue still exists, just tested, very bad

@mmattel mmattel removed the Stale label Mar 21, 2021
@TheOneRing TheOneRing added this to the 2.8.0 milestone Mar 22, 2021
@fmoc
Copy link
Contributor

fmoc commented May 14, 2021

On Linux on the latest master, resizing works in both directions. This is the minimal size I can achieve:

grafik

I'll check the .ui file and the C++ code to see where the minimum window size is set.

@fmoc
Copy link
Contributor

fmoc commented May 14, 2021

At a first glance, I can't find any code that would enforce a minimum size, it seems like Qt is to decide the initial and minimum sizes.

@TheOneRing resizing to a size smaller than the initial value is possible, at least in my tests.

TheOneRing added a commit that referenced this issue Aug 9, 2021
@TheOneRing TheOneRing linked a pull request Aug 9, 2021 that will close this issue
TheOneRing added a commit that referenced this issue Aug 12, 2021
@jnweiger
Copy link
Contributor

jnweiger commented Aug 23, 2021

image

This is the smallest I can get on windows, with 2.9.0-beta2

  • it is resizeable in x and y (to make it larger than in the screenhot)
  • it seems to implement a min of 2/3 height now. OK
  • (still quite large, showing much whitespace. Not sure why that 2/3 is a min, it could also be a max value, imo.)

@mmattel
Copy link
Contributor Author

mmattel commented Aug 23, 2021

Why can´t we add a content based appearing vertical scrollbar and size the blank area down to a minimum, lets say 3-4 blank lines? if a shown content fits, remove the scroll bar automatically, if not show it. I strongly believe that there are ready to use libraries in QT for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants