Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix window size when scaled #8874

Merged
merged 2 commits into from
Aug 12, 2021
Merged

Fix window size when scaled #8874

merged 2 commits into from
Aug 12, 2021

Conversation

TheOneRing
Copy link
Member

No description provided.

@TheOneRing TheOneRing linked an issue Aug 9, 2021 that may be closed by this pull request
Share window: vertical window resize not possible #8366
Closed
@TheOneRing
Copy link
Member Author 

14:48:48:801 AUT stdout: 08-09 14:48:47:896 [ info sync.propagator ]:	Completed propagation of "Photos/Teotihuacan.jpg" by OCC::PropagateDownloadFile(0x55de5de69a40) with status OCC::SyncFileItem::Success
2021-08-09T14:49:07	ERROR     	/drone/src/test/gui/shared/steps/steps.py:760: Script Error	LookupError: Object '{type='QMenu' unnamed='1' visible='1' window={name='Settings' type='OCC::SettingsDialog' visible='1'}}' not found. Could not match properties:\n    visible for object name: '{type='QMenu' unnamed='1' visible='1' window=:settings_OCC_SettingsDialog}'

I assume as we have no screen attached the resulting size is 0 or something like that...

@fmoc
Copy link
Contributor

fmoc commented Aug 12, 2021

Perhaps you need to add an absolute boundary again, e.g., 100x100?

fmoc
fmoc reviewed Aug 12, 2021
View reviewed changes
src/gui/settingsdialog.cpp Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Aug 12, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@TheOneRing TheOneRing merged commit fa138a2 into 2.9 Aug 12, 2021
@delete-merged-branch delete-merged-branch bot deleted the work/resize branch August 12, 2021 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmoc fmoc fmoc approved these changes

@erikjv erikjv Awaiting requested review from erikjv

@dschmidt dschmidt Awaiting requested review from dschmidt

@dragotin dragotin Awaiting requested review from dragotin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Share window: vertical window resize not possible
2 participants
@TheOneRing @fmoc